[SOLVED] restricting lights from a certain hour
-
At first blush, everything you've got there looks correct to me, and I would not expect the lights to go on during your "exclude" hours.
Some quick mental notes I made while reviewing:
- The XOR might be overkill in that last group; OR should suffice, since a day cannot be both a Weekday and Weekend;
- I prefer placing time constraints in Constraints, with the faster-moving conditions in Triggers;
- When you click on STATUS, does MSR throw you any warning message concerning host time vs. browser time?
Other than that, I got nothin' for ya at this early hour of the morning.
-
OK. Keep in mind that there's no guarantee to the order of rule evaluation. If two rules A and B both have conditions for 05:30, there's no guarantee which will be evaluated first. If it happens that B also depends on A directly, or on something A does, it's possible that if B is evaluated first, it will be looking at the "old" state of A because it hasn't updated yet. This may cause B to do some unexpected reaction. And worse, a moment later, A will be evaluated to its new state, and then B will see A changed and re-evaluate to the correct, expected state. This will happen so fast that the only way you'll see it is by examining the logs (or, you can add Notify/Alert actions to your reactions as a poor-man's debug stream). Leaving a wider window on time conditions can help with this as well. Other mitigation strategies may include moving time conditions that are often repeated into a rule, and then using the rule instead of the date/time condition(s).
In this particular case, you also don't really care if it's 5:30 in the constraints. You're thinking that way because that's when your day mode changes, but in fact, your time tests should probably just be before 6:30 and before 7:30. This would not be true if your "night" mode starts after midnight, but if it starts before, you're being too specific here.
If you don't change it to before, then put your ending times back to 6:30 and 7:30. You don't need to change those.
-
OK. Keep in mind that there's no guarantee to the order of rule evaluation. If two rules A and B both have conditions for 05:30, there's no guarantee which will be evaluated first. If it happens that B also depends on A directly, or on something A does, it's possible that if B is evaluated first, it will be looking at the "old" state of A because it hasn't updated yet. This may cause B to do some unexpected reaction. And worse, a moment later, A will be evaluated to its new state, and then B will see A changed and re-evaluate to the correct, expected state. This will happen so fast that the only way you'll see it is by examining the logs (or, you can add Notify/Alert actions to your reactions as a poor-man's debug stream). Leaving a wider window on time conditions can help with this as well. Other mitigation strategies may include moving time conditions that are often repeated into a rule, and then using the rule instead of the date/time condition(s).
In this particular case, you also don't really care if it's 5:30 in the constraints. You're thinking that way because that's when your day mode changes, but in fact, your time tests should probably just be before 6:30 and before 7:30. This would not be true if your "night" mode starts after midnight, but if it starts before, you're being too specific here.
If you don't change it to before, then put your ending times back to 6:30 and 7:30. You don't need to change those.
@toggledbits Wouldn't be the first time I've over-complicated the thinking...
This is where I am now given 99% of the time NIGHT is invoked before midnight. My m-i-l always says "nothing good happens after 9pm"
-
I think I'd "widen" those time slots by another 30 minutes (i.e. 5-7am / 5-8am), and give it another day of testing. Something tells me it's too precise for now, still. Nothing else jumps out at me, but as you've already pinpointed, Logs are your friend as is watching the Rule's live status in RuleSets.
-
I disagree. Unless the controller is down at the moment, one minute would be sufficient widening to prevent a race condition. There's something more here than meets the eye.
@gwp1 if you're going to send logs, don't snip, send me the whole thing, and also send all rules involved (if you click on the rule name in the Rule Sets list, it shows you the rule ID under the conditions -- there's a JSON file in your reactor/storage/rules with that ID as its base name).
-
Actually, before we go any further, look at this more carefully:
Let's say for the sake of argument that it's 4am. Your "not between" conditions are going to be true (4am is not between 5:30 and 7:30), so the condition is true, and that means your "exclusion" isn't.
For me, based on what I understand your intent to be, and working within the existing structure, you really want these to be after operators with the earliest time you're willing to accept the lights coming on.
-
Actually, before we go any further, look at this more carefully:
Let's say for the sake of argument that it's 4am. Your "not between" conditions are going to be true (4am is not between 5:30 and 7:30), so the condition is true, and that means your "exclusion" isn't.
For me, based on what I understand your intent to be, and working within the existing structure, you really want these to be after operators with the earliest time you're willing to accept the lights coming on.
@toggledbits Hmmm... that's an interesting approach. Mode + After alarm time = lights allowed. Let me try that.
Edited to add screenshot of updated ruleset:
-
@toggledbits Hmmm... that's an interesting approach. Mode + After alarm time = lights allowed. Let me try that.
Edited to add screenshot of updated ruleset:
@gwp1 Sadness abounds. Lights this morning. I've emailed @toggledbits the logs he requested in full.
Of note: when I was originally creating this rule I noticed something with the
WeekdayandWeekend"button/links"... when saved, the days chosen by using those were blank again. Only way I could save them visibly was by manually checking them. I should have filed a bug - work intervened and then it slipped my mind. Perhaps unrelated - perhaps not, if the choices aren't really saved. -
The log shows that this rule set at 20:28 and ran the "Rainstorm Lights ON" reaction from its set reaction. It remained set until 22:55, when it reset and ran the "Rainstorm lights OFF" reaction from its reset reaction.
The rule remained reset for the remainder of the log. It did not set at 05:30 or any other time, it did not start its set reaction or the "Rainstorm Lights ON" reaction it references.
However, the "Rainstorm Lights ON" reaction was run by another reaction at 05:30. So you've got a mention of this somewhere. I can't easily tell which (I'd need a higher level of debug), but it is probably one of active objects (or something they start):
- Rule Notify: Mode Day ON<SET>
- Rule Notify: Mode Night ON<RESET>
- Rule Notify: Screened room door<RESET>
- Cooling All Modes but Night: ON<SET>
- Reaction Sunset light group on
-
The log shows that this rule set at 20:28 and ran the "Rainstorm Lights ON" reaction from its set reaction. It remained set until 22:55, when it reset and ran the "Rainstorm lights OFF" reaction from its reset reaction.
The rule remained reset for the remainder of the log. It did not set at 05:30 or any other time, it did not start its set reaction or the "Rainstorm Lights ON" reaction it references.
However, the "Rainstorm Lights ON" reaction was run by another reaction at 05:30. So you've got a mention of this somewhere. I can't easily tell which (I'd need a higher level of debug), but it is probably one of active objects (or something they start):
- Rule Notify: Mode Day ON<SET>
- Rule Notify: Mode Night ON<RESET>
- Rule Notify: Screened room door<RESET>
- Cooling All Modes but Night: ON<SET>
- Reaction Sunset light group on
@toggledbits
"this rule set at 20:28 and ran the "Rainstorm Lights ON" reaction from its set reaction. It remained set until 22:55, when it reset and ran the "Rainstorm lights OFF" reaction from its reset reaction."Yes, makes sense as this rule gets included in the @sunset rule for those two lights it controls. That would be sunset (20:28 until sleep time 22:55).
Reaction Sunset light group oncontains the rest of the lights that come on at sunset, of which this is a subset.I'll look at what's happening at 05:30 (IIFC it's just a mode change ruleset).
Rule Notify: Mode Day ON<SET>This is the 05:30 mode change
Rule Notify: Mode Night ON<RESET>I would gather this is Night Mode ON deactivating
Rule Notify: Screened room door<RESET>This is the screened room door sensor alert being turned off after Night mode is deactivated
Cooling All Modes but Night: ON<SET>This is HVAC switching from Night Mode to everything else with the mode change. -
@toggledbits
"this rule set at 20:28 and ran the "Rainstorm Lights ON" reaction from its set reaction. It remained set until 22:55, when it reset and ran the "Rainstorm lights OFF" reaction from its reset reaction."Yes, makes sense as this rule gets included in the @sunset rule for those two lights it controls. That would be sunset (20:28 until sleep time 22:55).
Reaction Sunset light group oncontains the rest of the lights that come on at sunset, of which this is a subset.I'll look at what's happening at 05:30 (IIFC it's just a mode change ruleset).
Rule Notify: Mode Day ON<SET>This is the 05:30 mode change
Rule Notify: Mode Night ON<RESET>I would gather this is Night Mode ON deactivating
Rule Notify: Screened room door<RESET>This is the screened room door sensor alert being turned off after Night mode is deactivated
Cooling All Modes but Night: ON<SET>This is HVAC switching from Night Mode to everything else with the mode change.@gwp1 "However, the "Rainstorm Lights ON" reaction was run by another reaction at 05:30."
Wouldn't it be triggered because of the mode change? Mode (either day or evening) is a trigger for
Rainstorm lights ON- but having the time restriction should stop it from turning on those lights, no? -
No, it looks like something else, not the rule we've been looking at, is running that reaction. The rule never went true/set after 22:55
-
No, it looks like something else, not the rule we've been looking at, is running that reaction. The rule never went true/set after 22:55
@toggledbits
Rule ID: rule-198should runRainstorm Lights ONreactions plusSunset Light group ONreaction together to equal turning on all necessary lighting at sunset. -
Something ran "Rainstorm Lights ON" at 05:30. It was likely one of the rules or the reaction I listed above, as those were active at the time. The rule "Rainstorm: on, off with UV" was not active at this time, so it did not run it.
-
Something ran "Rainstorm Lights ON" at 05:30. It was likely one of the rules or the reaction I listed above, as those were active at the time. The rule "Rainstorm: on, off with UV" was not active at this time, so it did not run it.
@toggledbits Rule Notify: Mode Day ON<SET> This is the 05:30 mode change and the mode change is a condition for the running of
Rainstorm Lights ON- but shouldn't/wouldn't the conditions aroundnot before <xx time>belay that order? (That was my intent, anyway.)Would moving the time conditions to
Constraintsbe a better approach?
