Upgrade Issues

[tamorgen]

@toggledbits,
Okay, thanks. I don't receive any other errors, and it only appears when I initially load the page or do a refresh.

[gwp1]

@toggledbits hate to pile on... I got this:

    at _ClientAPI.sendrpc (https://192.168.1.241:8554/client/ClientAPI.js:309:45)
    at _ClientAPI.echo (https://192.168.1.241:8554/client/ClientAPI.js:649:31)
    at HTMLAnchorElement.handleTabClick (https://192.168.1.241:8554/reactor/en-US/lib/js/reactor-ui-core.js:132:13)
    at HTMLAnchorElement.dispatch (https://192.168.1.241:8554/node_modules/jquery/dist/jquery.min.js:2:40035)
    at v.handle (https://192.168.1.241:8554/node_modules/jquery/dist/jquery.min.js:2:38006)

This was after using Tools > Restart Reactor because I wanted to ensure everything was good back and forth between Hubitat and MSR. I'm missing capabilities from my Roborock that were there prior to the release upgrade, specifically appScene and appRoomClean and appRoomResume. No updates have been made to the app in Hubitat, those capabilities are still there.

[toggledbits]

@gwp1 said in Error on start for MSR after update to 24293:

@toggledbits hate to pile on... I got this:

Rules of engagement haven't changed. That's clearly redacted content you posted, with no source... pop-up modal dialog? In the browser log stream? Where's the first line of the error saying what the error actually is?

@gwp1 said in Error on start for MSR after update to 24293:

I'm missing capabilities from my Roborock that were there prior to the release upgrade, specifically appScene and appRoomClean and appRoomResume.

Open a separate thread for a separate problem. That said, those aren't Reactor capabilities, so be really detailed (per the posting guidelines) with what you give me there. Thank you.

[gwp1]

@toggledbits yes, I'd planned to split out the Roborock issue but included it above in case it provided value to troubleshooting.

To the original issue, the content is from a pop-up, yes.

Steps to reproduce: Tools > Restart Reactor

Result:

Following the guidance, I did not screenshot it initially. Clicking on the text auto-highlights it; I present it here:

ReferenceError: payload is not defined
    at _ClientAPI.sendrpc (https://192.168.1.241:8554/client/ClientAPI.js:309:45)
    at _ClientAPI.echo (https://192.168.1.241:8554/client/ClientAPI.js:649:31)
    at HTMLAnchorElement.handleTabClick (https://192.168.1.241:8554/reactor/en-US/lib/js/reactor-ui-core.js:132:13)
    at HTMLAnchorElement.dispatch (https://192.168.1.241:8554/node_modules/jquery/dist/jquery.min.js:2:40035)
    at v.handle (https://192.168.1.241:8554/node_modules/jquery/dist/jquery.min.js:2:38006)

As to the separate issue... doing another Testing > Restart Reactor to obtain the above screenshot appears to have fixed the issue - the missing capabilities/commands are back and the rules are no longer erroring.

[toggledbits]

OK. That's benign, I think. I'm guessing you are switching to another tab pretty quickly, while the restart and browser-side reconnect are still happening. When you switch tabs, there's a query made to the Reactor service (which isn't running at that moment), and that's what's failing. If you wait on the Tools tab until Reactor reports it's connected again, then switch tabs, I'll bet you don't get the error.

[gwp1]

@toggledbits Yes, if I am patient and don't touch anything until MSR is showing green/CONNECTED it does not occur.

Patience is a tall order before 0900 EDT sans coffee on a Monday...

[toggledbits]

As I said, it's a benign message. I'll make sure it's not so picky on the next build.

[tamorgen]

modules:composer.user-said-in, @gwp1, Error on start for MSR after update to 24293

Patience is a tall order before 0900 EDT sans coffee on a Monday

Get some coffee

Glad I'm not the only one that had the error. I thought I broke something.

[toggledbits]

By the way, just so you all know, all of these errors were happening before this build, you just didn't see them. The code structure that allowed the race condition that opened this thread has been there since 2021; few would get it, and maybe not even consistently (the nature of race conditions), and when it happened, it would just be logged in the browser console (which most people don't have up) but otherwise not much effect. Same with the post-restart tab switch message -- logged quietly in a place nobody ever looked. When I added the global error handling, a bunch of things crawled out of the woodwork... as they say, sunlight is a good disinfectant. A ton of things were found and fixed by that before releasing this build, but there will always be differences in the way I approach the app vs how everyone else does, so now your eyes are on things I wouldn't easily see. Alarming, maybe, but not harmful so far, and finding these things and fixing them really improves code quality. I suspect we'll have a few more of these in the coming weeks, but just report and keep on doing what you're doing (in the app and generally).

[gwp1]

@toggledbits ignorance is bliss