Reactor-Editor / Reactor-ui-Status Errors

[toggledbits]

Working for me:

C:\Users\Patrick\Documents\MSR>set NODE_PATH=C:\Users\Patrick\Documents\MSR

C:\Users\Patrick\Documents\MSR>node app.js
basedir C:\Users\Patrick\Documents\MSR
confdir C:\Users\Patrick\Documents\MSR\config
datadir C:\Users\Patrick\Documents\MSR\storage
logsdir C:\Users\Patrick\Documents\MSR\logs
plugindir C:\Users\Patrick\Documents\MSR\ext
module.paths [
  'C:\\Users\\Patrick\\Documents\\MSR\\node_modules',
  'C:\\Users\\Patrick\\Documents\\node_modules',
  'C:\\Users\\Patrick\\node_modules',
  'C:\\Users\\node_modules',
  'C:\\node_modules'
]
NODE_PATH C:\Users\Patrick\Documents\MSR
2021-08-12T18:39:38.096Z <app:null> Reactor ###BUILDVERSION### starting on v14.15.5
2021-08-12T18:39:38.097Z <app:INFO> Process ID 26416; platform win32/x64 Windows 10 Pro
2021-08-12T18:39:38.099Z <app:INFO> Basedir C:\Users\Patrick\Documents\MSR; data in C:\Users\Patrick\Documents\MSR\storage
2021-08-12T18:39:38.099Z <app:INFO> NODE_PATH C:\Users\Patrick\Documents\MSR; module paths [ "C:\\Users\\Patrick\\Documents\\MSR\\node_modules", "C:\\Users\\Patrick\\Documents\\node_modules", "C:\\Users\\Patrick\\node_modules", "C:\\Users\\node_modules", "C:\\node_modules" ]
2021-08-12T18:39:38.100Z <app:INFO> process.env=[object Object]
2021-08-12T18:39:38.100Z <app:INFO> process.env.TEST=(undefined)
2021-08-12T18:39:38.145Z <Plugin:null> Module Plugin v21173
2021-08-12T18:39:38.152Z <default:INFO> Module Entity v21177
2021-08-12T18:39:38.155Z <Controller:null> Module Controller v21191
2021-08-12T18:39:38.156Z <default:null> Module Structure v21216
2021-08-12T18:39:38.162Z <default:null> Module Ruleset v21096
2021-08-12T18:39:38.162Z <default:null> Module Rulesets v21096
2021-08-12T18:39:38.181Z <default:null> Module Rule v21221
2021-08-12T18:39:38.185Z <default:null> Module Engine v21213
2021-08-12T18:39:38.186Z <default:null> Module httpapi v21215
2021-08-12T18:39:38.189Z <default:null> Module httpproxy v21054
2021-08-12T18:39:38.209Z <default:null> Module wsapi v21196
2021-08-12T18:39:38.212Z <app:NOTICE> Starting Structure...
2021-08-12T18:39:38.214Z <Structure:NOTICE> Structure#1 plugin ID influx disabled; skipping
2021-08-12T18:39:38.216Z <Structure:INFO> Structure#1 starting controller interface ezlo (EzloController)
2021-08-12T18:39:38.220Z <Structure:INFO> Structure#1 starting controller interface reactor_system (SystemController)
2021-08-12T18:39:38.249Z <default:null> Module EzloController v21218
2021-08-12T18:39:38.251Z <default:null> Module SystemController v21102
2021-08-12T18:39:38.254Z <EzloController:null> EzloController#ezlo created, config { "source": "wss://192.168.0.67:17000", "serial": "900xxxxx", "username": "xxxxx", "password": "xxxxx", "auto_rediscover": false }
2021-08-12T18:39:38.255Z <EzloController:null> EzloController#ezlo instance log level (null) (4)
2021-08-12T18:39:38.269Z <Controller:INFO> EzloController#ezlo device mapping data loaded; checking...
2021-08-12T18:39:38.272Z <Controller:INFO> EzloController#ezlo performing cloud auth to get local access token
2021-08-12T18:39:38.324Z <Controller:NOTICE> Controller SystemController#reactor_system is now online.
2021-08-12T18:39:38.395Z <app:INFO> Structure running; pausing for controllers' initial ready
2021-08-12T18:39:39.934Z <Controller:INFO> EzloController#ezlo cloud auth phase complete (local access token acquired)
2021-08-12T18:39:39.936Z <Controller:INFO> EzloController#ezlo opening local hub connection to "900xxxxx" at wss://192.168.0.67:17000
2021-08-12T18:39:39.938Z <Controller:NOTICE> EzloController#ezlo configured to ignore host ("900xxxxx") certificate
2021-08-12T18:39:39.940Z <Controller:NOTICE> EzloController#ezlo connecting via WS to wss://192.168.0.67:17000
2021-08-12T18:39:40.038Z <Controller:NOTICE> EzloController#ezlo successful hub login; performing inventory
2021-08-12T18:39:40.227Z <Controller:INFO> EzloController#ezlo data load complete; 21 devices received, 26 entities registered; 66 items.
2021-08-12T18:39:40.227Z <Controller:INFO> EzloController#ezlo hub inventory complete/successful; 187ms
2021-08-12T18:39:40.229Z <Controller:NOTICE> Controller EzloController#ezlo is now online.
2021-08-12T18:39:40.231Z <app:NOTICE> Starting Reaction Engine...
2021-08-12T18:39:40.233Z <Engine:INFO> Reaction Engine starting
2021-08-12T18:39:40.234Z <Engine:INFO> Checking rule sets...
2021-08-12T18:39:40.237Z <Engine:INFO> Checking rules...
2021-08-12T18:39:40.237Z <Engine:INFO> Data check complete; no corrections.
2021-08-12T18:39:40.240Z <Engine:NOTICE> Reaction Engine running!
2021-08-12T18:39:40.241Z <app:NOTICE> Starting HTTP server and API...
2021-08-12T18:39:40.245Z <app:NOTICE> Startup complete
2021-08-12T18:39:40.249Z <httpapi:NOTICE> HTTP API v1 21215 base URL http://192.168.0.164:8111; listening
2021-08-12T18:39:40.258Z <app:NOTICE> HTTP server running; registering proxy endpoints.
2021-08-12T18:39:40.259Z <app:NOTICE> Starting WSAPI...
2021-08-12T18:39:40.260Z <wsapi:NOTICE> wsapi: starting version 21196
2021-08-12T18:39:40.343Z <Engine:INFO> Engine#1 master timer tick, local time "8/12/2021, 2:39:40 PM" (TZ offset -240 mins from UTC)

Your snippets don't show the current startup information, which would be useful. Make sure that NODE_PATH appears with the correct value in the startup messages, as shown in the log above.

Also works under PowerShell:

PS C:\Users\Patrick\Documents\MSR> $env:NODE_PATH = 'C:\Users\Patrick\Documents\MSR'
PS C:\Users\Patrick\Documents\MSR> $env:NODE_PATH
C:\Users\Patrick\Documents\MSR
PS C:\Users\Patrick\Documents\MSR> node app.js
basedir C:\Users\Patrick\Documents\MSR
confdir C:\Users\Patrick\Documents\MSR\config
datadir C:\Users\Patrick\Documents\MSR\storage
logsdir C:\Users\Patrick\Documents\MSR\logs
plugindir C:\Users\Patrick\Documents\MSR\ext
module.paths [
  'C:\\Users\\Patrick\\Documents\\MSR\\node_modules',
  'C:\\Users\\Patrick\\Documents\\node_modules',
  'C:\\Users\\Patrick\\node_modules',
  'C:\\Users\\node_modules',
  'C:\\node_modules'
]
NODE_PATH C:\Users\Patrick\Documents\MSR
2021-08-12T18:45:56.225Z <app:null> Reactor ###BUILDVERSION### starting on v14.15.5
2021-08-12T18:45:56.226Z <app:INFO> Process ID 25296; platform win32/x64 Windows 10 Pro
2021-08-12T18:45:56.227Z <app:INFO> Basedir C:\Users\Patrick\Documents\MSR; data in C:\Users\Patrick\Documents\MSR\storage
2021-08-12T18:45:56.227Z <app:INFO> NODE_PATH C:\Users\Patrick\Documents\MSR; module paths [ "C:\\Users\\Patrick\\Documents\\MSR\\node_modules", "C:\\Users\\Patrick\\Documents\\node_modules", "C:\\Users\\Patrick\\node_modules", "C:\\Users\\node_modules", "C:\\node_modules" ]
2021-08-12T18:45:56.228Z <app:INFO> process.env=[object Object]
2021-08-12T18:45:56.228Z <app:INFO> process.env.TEST=(undefined)
2021-08-12T18:45:56.271Z <Plugin:null> Module Plugin v21173
2021-08-12T18:45:56.279Z <default:INFO> Module Entity v21177
2021-08-12T18:45:56.282Z <Controller:null> Module Controller v21191
2021-08-12T18:45:56.283Z <default:null> Module Structure v21216
2021-08-12T18:45:56.287Z <default:null> Module Ruleset v21096
2021-08-12T18:45:56.287Z <default:null> Module Rulesets v21096
2021-08-12T18:45:56.303Z <default:null> Module Rule v21221
2021-08-12T18:45:56.310Z <default:null> Module Engine v21213
2021-08-12T18:45:56.310Z <default:null> Module httpapi v21215
2021-08-12T18:45:56.312Z <default:null> Module httpproxy v21054
2021-08-12T18:45:56.332Z <default:null> Module wsapi v21196
2021-08-12T18:45:56.334Z <app:NOTICE> Starting Structure...
2021-08-12T18:45:56.338Z <Structure:NOTICE> Structure#1 plugin ID influx disabled; skipping
2021-08-12T18:45:56.339Z <Structure:INFO> Structure#1 starting controller interface ezlo (EzloController)
2021-08-12T18:45:56.344Z <Structure:INFO> Structure#1 starting controller interface reactor_system (SystemController)
2021-08-12T18:45:56.370Z <default:null> Module EzloController v21218
2021-08-12T18:45:56.372Z <default:null> Module SystemController v21102
2021-08-12T18:45:56.375Z <EzloController:null> EzloController#ezlo created, config { "source": "wss://192.168.0.67:17000", "serial": "900xxxxx", "username": "xxxxx", "password": "xxxxx", "auto_rediscover": false }
2021-08-12T18:45:56.375Z <EzloController:null> EzloController#ezlo instance log level (null) (4)
2021-08-12T18:45:56.385Z <Controller:INFO> EzloController#ezlo device mapping data loaded; checking...
2021-08-12T18:45:56.386Z <Controller:INFO> EzloController#ezlo performing cloud auth to get local access token
2021-08-12T18:45:56.441Z <Controller:NOTICE> Controller SystemController#reactor_system is now online.
2021-08-12T18:45:56.518Z <app:INFO> Structure running; pausing for controllers' initial ready
2021-08-12T18:45:59.726Z <Controller:INFO> EzloController#ezlo cloud auth phase complete (local access token acquired)
2021-08-12T18:45:59.727Z <Controller:INFO> EzloController#ezlo opening local hub connection to "900xxxxx" at wss://192.168.0.67:17000
2021-08-12T18:45:59.727Z <Controller:NOTICE> EzloController#ezlo configured to ignore host ("900xxxxx") certificate
2021-08-12T18:45:59.729Z <Controller:NOTICE> EzloController#ezlo connecting via WS to wss://192.168.0.67:17000
2021-08-12T18:45:59.823Z <Controller:NOTICE> EzloController#ezlo successful hub login; performing inventory
2021-08-12T18:46:00.006Z <Controller:INFO> EzloController#ezlo data load complete; 21 devices received, 26 entities registered; 66 items.
2021-08-12T18:46:00.006Z <Controller:INFO> EzloController#ezlo hub inventory complete/successful; 182ms
2021-08-12T18:46:00.007Z <Controller:NOTICE> Controller EzloController#ezlo is now online.
2021-08-12T18:46:00.008Z <app:NOTICE> Starting Reaction Engine...
2021-08-12T18:46:00.009Z <Engine:INFO> Reaction Engine starting
2021-08-12T18:46:00.009Z <Engine:INFO> Checking rule sets...
2021-08-12T18:46:00.012Z <Engine:INFO> Checking rules...
2021-08-12T18:46:00.012Z <Engine:INFO> Data check complete; no corrections.
2021-08-12T18:46:00.016Z <Engine:NOTICE> Reaction Engine running!
2021-08-12T18:46:00.017Z <app:NOTICE> Starting HTTP server and API...
2021-08-12T18:46:00.022Z <app:NOTICE> Startup complete
2021-08-12T18:46:00.026Z <httpapi:NOTICE> HTTP API v1 21215 base URL http://192.168.0.164:8111; listening
2021-08-12T18:46:00.039Z <app:NOTICE> HTTP server running; registering proxy endpoints.
2021-08-12T18:46:00.040Z <app:NOTICE> Starting WSAPI...
2021-08-12T18:46:00.042Z <wsapi:NOTICE> wsapi: starting version 21196
2021-08-12T18:46:00.123Z <Engine:INFO> Engine#1 master timer tick, local time "8/12/2021, 2:46:00 PM" (TZ offset -240 mins from UTC)

[Fanan]

@toggledbits
Thanks! I now seem to have overcome the NODE_PATH.... So the next problem arise. I now get a message related to the Ezlo plus: "... ezlo failed to authenticate: Error: Request failed: 404 NOT FOUND."

I did a screenshot, so that I could easily hide my credentials. I have used my username as I use for both my Vera and Ezlo. I have checked them over and over - and they are correct. Is it something connected to the " "? Or what could it be?

The last lines are:

2021-08-13T12:04:13.950Z <Controller:ERR> EzloController#ezlo failed to authenticate: Error: Request failed: 404 NOT FOUND
2021-08-13T12:04:13.951Z <Controller:ERR> EzloController#ezlo failed to log in: auth failed
2021-08-13T12:04:15.034Z <VeraController:NOTICE> Controller VeraController#vera is now online.
2021-08-13T12:04:18.963Z <Controller:INFO> EzloController#ezlo performing cloud auth to get local access token
2021-08-13T12:04:19.460Z <Controller:ERR> EzloController#ezlo failed to authenticate: Error: Request failed: 404 NOT FOUND
2021-08-13T12:04:19.461Z <Controller:ERR> EzloController#ezlo failed to log in: auth failed
2021-08-13T12:04:24.470Z <Controller:INFO> EzloController#ezlo performing cloud auth to get local access token
2021-08-13T12:04:24.955Z <Controller:ERR> EzloController#ezlo failed to authenticate: Error: Request failed: 404 NOT FOUND
2021-08-13T12:04:24.956Z <Controller:ERR> EzloController#ezlo failed to log in: auth failed

[toggledbits]

Username or password is incorrect. The "NOT FOUND" it is referring to is you.

[Fanan]

@toggledbits
I also thought so. But it's not incorrect. I even tried to create another user profile. The profile is able to log in to Vera/Ezlo. But when I use the profiles credentials, I get the same error. I changed between my true profile and the test profile - and always get the same result. So it's more to the story.
This is from my yaml file. I guess it looks alright?

[toggledbits]

Are there any special characters in the password, like international characters? Also what region are you in?

[Fanan]

Yes, there is a @ in my password. I'm in Europe/Sweden.

Vera/Ezlo has these demands on the passwords:
Password must be at least 8 characters long and include:

• at least one lowercase letter;
• at least one special character;
• uppercase letters or numbers.

[toggledbits]

Is your username capitalized?

[Fanan]

@toggledbits
Yes. Everywhere.

[toggledbits]

OK. That's probably it. Try creating an account with an all lower-case username. Password is fine.

[Fanan]

Thanks! It worked! Finally after so many hours.... It was the low-case username that did the trick!
Have a great weekend Patrick!
/Fanan

[toggledbits]

Excellent news. That's a bug I can fix, so I'll make sure that's in the next build and you can use your username the way you want it to be.

[cw-kid]

@toggledbits

"Note that Generation 1 Atoms are supported in this version, but only through the remote access API (so it's cloud-dependent). Gen2 and later Atoms/PlugHubs can run with local/LAN access (no cloud dependency)."

Did you hear back from the Ezlo devs with the needed information for this? Or have you just gone ahead and used the learned knowledge from the forum ?

My Atom is now at firmware version 0.8.539. However I am not totally sure if its a gen1 or gen2 Atom? I think its gen2 but not sure.

Its still not appearing in the MSR Entities area however.

I have tried with "set_anonymous_access: true" commented out and not commented out in the reactor.yaml file.

I can't see anything in the MSR log to do with the Atom controller only the Ezlo Plus controller.

Thanks

[toggledbits]

I have heard nothing from the eZLO devs on anything. That's business as usual. Everything I've done, everything that everyone has done, in this respect has been done based on hearsay and tribal knowledge, no specifications or documentation from eZLO. May stop working at any time.

Sounds like you have a Gen1 atom. You have to configure for cloud/remote access, it doesn't switch back and forth automatically. That involves just commenting out the source field. If the source field is not present, then the EzloController uses remote access to get to the device. But, there's bug that leaked in the remote access login that I just fixed. Are you on a docker container or bare metal install?

The set_anonymous_access field is not available for Atom and PlugHub; it is not supported on these platforms.

[cw-kid]

@toggledbits

Bare metal Linux Debian install.

I did try to comment out the source line earlier. I just tried again now. I also have set_anonymous_access commented out.

The serial number of the Atom and the username and password look OK. Restarted MSR but still nothing in entities.

If I login to https://home.getvera.com/ with same username and password I can see that Atom listed in the controllers.

- id: ezlo-atom
  enabled: false
  implementation: EzloController
  name: Ezlo Atom
  config:
    # source: "wss://192.168.0.243:17000"  # change the IP address
    serial: "70060304"    # put your hub's serial here
    username: "myusername"  # put your username here between quotes
    password: "mypassword"  # and password
    # set_anonymous_access: true

In the MSR log I see no mention of the word "atom"

Maybe I need your bug fix first then.

Cheers.

EDIT:

Bugger just spotted it says enabled "false" maybe that's why.

[cw-kid]

OK its listed now in Entities

Still not sure if this is gen 1 or 2 ? It was sent to me by Ezlo as part of their beta program.

Also not seeing the one Z-Wave device that is currently paired to that Atom a TKB Home RGBW module.

[cw-kid]

It says:

sys_system.state=false

Which I assume means its a gen 1 Atom ?

[cw-kid]

Looking in the log I now see this, I have changed some sensitive items:

2021-08-25T14:54:50.826Z <EzloController:null> EzloController#ezlo-atom account server replied { "PK_Device": "70060304", "NMAControllerStatus": 1, "NMAUuid": "a12bgd83-96b3-22d9-ad44-533df5564f44", "firmware_upgrade_progress": 100, "firmware_upgrade_status": "finished", "public_key_android": "", "public_key_ios": "", "Server_Relay": "wss://nma-server6-ui-cloud.ezlo.com:443", "MacAddress": "54:F5:4E:A4:5E:E5", "FK_Branding": "1", "HasWifi": "0", "HasAlarmPanel": "0", "UI": "4", "EngineStatus": "0", "LinuxFirmware": 1 }
2021-08-25T14:54:50.828Z <EzloController:INFO> EzloController#ezlo-atom cloud auth succeeded
2021-08-25T14:54:50.829Z <EzloController:6:EzloController.js:660> EzloController#ezlo-atom authinfo {  }
2021-08-25T14:54:50.830Z <EzloController:INFO> EzloController#ezlo-atom opening hub connection to "70060304" at wss://nma-server6-ui-cloud.ezlo.com:443
2021-08-25T14:54:50.832Z <EzloController:NOTICE> EzloController#ezlo-atom connecting via WS to wss://nma-server6-ui-cloud.ezlo.com:443
2021-08-25T14:54:50.834Z <EzloController:5:Controller.js:537> EzloController#ezlo-atom websocket options { "maxPayload": 268435456, "followRedirects": true, "pingInterval": 60000, "agent": [object Object], "handshakeTimeout": 30000 }
2021-08-25T14:54:51.518Z <EzloController:6:Controller.js:554> EzloController#ezlo-atom websocket connected to wss://nma-server6-ui-cloud.ezlo.com:443; starting ping check timer Timer#ezlo-atom-ping
2021-08-25T14:54:51.519Z <EzloController:INFO> EzloController#ezlo-atom hub websocket connected (wss://nma-server6-ui-cloud.ezlo.com:443)
2021-08-25T14:54:51.520Z <EzloController:INFO> EzloController#ezlo-atom sending remote hub login
2021-08-25T14:54:51.522Z <EzloController:7:EzloController.js:1848> EzloController#ezlo-atom sending tracked request "17c8dcd8491" payload { "api": "1.0", "id": "17b7dce8481", "method": "loginUserMios", "params": { "MMSAuth": --undef--, "MMSAuthSig": --undef-- } }
2021-08-25T14:54:51.523Z <EzloController:5:EzloController.js:1856> EzloController#ezlo-atom created tracked request "17c8dcd8491" with payload { "api": "1.0", "id": "17b7dce8481", "method": "loginUserMios", "params": { "MMSAuth": --undef--, "MMSAuthSig": --undef-- } }
2021-08-25T14:54:51.675Z <EzloController:5:EzloController.js:1419> EzloController#ezlo-atom received message 144 bytes
2021-08-25T14:54:51.676Z <EzloController:5:EzloController.js:1419> EzloController#ezlo-atom message data {"id":"17b7dce8481","method":"loginUserMios","error":{"code":2,"data":"cloud.error.failed_to_get_mms_autha_token","description":""},"result":{}}
2021-08-25T14:54:51.678Z <EzloController:7:EzloController.js:1423> EzloController#ezlo-atom tracked request result slot { "req_id": "17c8dcd8491", "req_method": "loginUserMios", "expires": 1629903306521, "resolve": --function--, "reject": --function--, "promise": [object Promise] }
2021-08-25T14:54:51.679Z <EzloController:ERR> EzloController#ezlo-atom request "17c8dcd8491" (loginUserMios) failed: { "code": 2, "data": "cloud.error.failed_to_get_mms_autha_token", "description": "" }
2021-08-25T14:54:51.680Z <EzloController:7:EzloController.js:1855> EzloController#ezlo-atom removing resolved tracked request "17c8dcd8491"
2021-08-25T14:54:51.681Z <EzloController:ERR> EzloController#ezlo-atom hub login failed: { "code": 2, "data": "cloud.error.failed_to_get_mms_autha_token", "description": "" }
2021-08-25T14:54:51.685Z <EzloController:5:Controller.js:560> EzloController#ezlo-atom got websocket close
2021-08-25T14:54:51.686Z <EzloController:NOTICE> EzloController#ezlo-atom websocket closing, 1006 

And as I said no devices from the Atom are being pulled in to MSR. Maybe at this stage I need your bug fix then..

[toggledbits]

OK. Since it's a minor change, I just patched the build. Re-download the build package and reinstall it for the update. Then, you should be able to start with source commented out and get remote access.

Once you have it connected, look at the system entity (the one with ID "system" matching the controller ID, like atom>system), and there is a hardware attribute that tells you the generation of Atom.

[cw-kid]

@toggledbits

Its connected now and has imported the devices and scenes from the Atom in to entities area.

I see this though in alerts:

x_ezlo_sys.hardware="rev2"

So what's rev2 ?

sys_system.state=true
x_ezlo_sys.anonymous_access_enabled=null
x_ezlo_sys.architecture="esp32"
x_ezlo_sys.firmware="0.8.539"
x_ezlo_sys.hardware="rev2"
x_ezlo_sys.kernel="v4.1-rc-4-gbd72a9ab2"
x_ezlo_sys.model="ATOM32"
x_ezlo_sys.reconnects=1
x_ezlo_sys.restarts=1
x_ezlo_sys.serial="70060304"
x_ezlo_sys.support_enabled=null
x_ezlo_sys.support_status=null
x_ezlo_sys.temperature_scale="fahrenheit"
x_ezlo_sys.temperature_unit="F"
x_ezlo_sys.upsince=1624528447000
x_ezlo_sys.using_cloud_auth=true
x_ezlo_sys.using_cloud_relay=true
x_ezlo_sys.uuid=null
Capabilities: sys_system, x_ezlo_sys
Actions: sys_system.restart, x_ezlo_sys.runlua, x_ezlo_sys.set_setting

Thanks

[toggledbits]

That's gen2, so you may have local access. If you want to use local access, your Atom needs a stable IP address (static or DHCP reserved). You can put that into the source field (uncomment now), and also set disable_ecc_ciphers to true. Then restart Reactor.

  config:
    source: "wss://your-atom-ip:17000"
    serial: "7006nnnn"
    username: "whatever"
    password: "whatever"
    disable_ecc_ciphers: true

This may or may not work for you. My rev2 Atom is on firmware 0.8.798, and it allows remote access. I don't have an Atom with 0.8.539 that is at rev2, so I don't know if rev2 will work at that firmware level. I do have a rev3 Atom at 0.8.539, and it does allow remote access, so I think it should, but we'll see...