[Reactor] Help with screne controller cycling logic

[Andr]

So it was time to update MSR (and then HA but I got stuck here)
Can't figure out what I have missed.

My installed version of MSR was 22240.
Node.js is version 16.15.1

First I tried to update, following online manual.

||Download a Reactor distribution ZIP from https://reactor.toggledbits.com/download/ and place it in the folder above your existing reactor (runtime) directory.
Stop and remove any existing Reactor service:

cd \path\to\reactor
node tools\install_reactor_windows_service.js -u .
Remove any existing package-lock.json file from your Reactor directory.

Unzip the archive file and copy its contents over the contents of your existing Reactor install directory.
From the Reactor install directory, re-install/upgrade all package dependencies:

npm install --no-save --omit dev
If you are running Reactor as a Windows service, repeat those steps above.

Restart Reactor (restart the service).
Hard-refresh all browsers that are displaying Reactor content.||

I found several (maybe it was 3) package-lock.json and I deleted all I could search in reactor folder.
Unzip the new version and replaced old existing files.

Install the reactor service again by instructions.

||In a command prompt window, running as Administrator, change directory to your Reactor install directory.
Install the node-windows package as a global package (it must be global or the service will not work, and you must install the specific version provided by the command below):

npm uninstall node-windows
npm uninstall -g node-windows
npm install -g node-windows@1.0.0-beta.6
npm link node-windows
Run the script to install:

node tools\install_reactor_windows_service.js -i .||

So this failed. Service wont start.

Tried again.

Then deleted everything exept my config folder and did a new install.
Also downloaded 22310 again, but from "latest" build instead of "stable"
When running node app.js in command promt i get some kind of error message:

c:\reactor>node app.js
Reactor latest-22310-a6da8097 app 22310 configuration from c:\reactor\config
NODE_PATH C:\reactor
[latest-22310]2022-11-23T22:18:43.030Z <app:null> Reactor build latest-22310-a6da8097 starting on v16.15.1
c:\reactor\app.js:277
log['always'](a0_0x3d42be(0x26a), BUILD_VERSION, process['version']), log['always']('Process\x20ID\x20%1\x20user/group\x20%2/%3;\x20%4;\x20platform\x20%5/%6\x20%7;\x20locale\x20%8', process['pid'], process[a0_0x3d42be(0x269)](), process[a0_0x3d42be(0x278)](), is_docker ? 'docker' : a0_0x3d42be(0x288), process[a0_0x3d42be(0x287)], process['arch'], os[a0_0x3d42be(0x263)](), sys_locale), log[a0_0x3d42be(0x28c)]('Basedir\x20%1;\x20data\x20in\x20%2', c[a0_0x3d42be(0x1f8)], c[a0_0x3d42be(0x27b)]), log[a0_0x3d42be(0x28c)](a0_0x3d42be(0x21b), process['env'][a0_0x3d42be(0x291)]);
                                                                                                                                                                                                                                 ^

TypeError: process[a0_0x3d42be(...)] is not a function
    at Object.<anonymous> (c:\reactor\app.js:277:226)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
    at node:internal/main/run_main_module:17:47

But I can't figure out what TypeError means?

Also, before I tried a new install, there apperd an warning when installing reactor service.

c:\reactor>npm install -g node-windows@1.0.0-beta.6
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.

added 5 packages, and audited 6 packages in 3s

2 vulnerabilities (1 moderate, 1 critical)

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

Running npm audit fix --force seems to broke something, because I could not install service after that.

c:\reactor>npm audit fix --force
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
npm WARN using --force Recommended protections disabled.

up to date, audited 89 packages in 826ms

12 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

c:\reactor>node tools\install_reactor_windows_service.js -i .
node:internal/modules/cjs/loader:936
  throw err;
  ^

Error: Cannot find module 'node-windows'
Require stack:
- c:\reactor\tools\install_reactor_windows_service.js
←[90m    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)←[39m
←[90m    at Function.Module._load (node:internal/modules/cjs/loader:778:27)←[39m
←[90m    at Module.require (node:internal/modules/cjs/loader:1005:19)←[39m
←[90m    at require (node:internal/modules/cjs/helpers:102:18)←[39m
    at Object.<anonymous> (c:\reactor\tools\install_reactor_windows_service.js:102:15)
←[90m    at Module._compile (node:internal/modules/cjs/loader:1105:14)←[39m
←[90m    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)←[39m
←[90m    at Module.load (node:internal/modules/cjs/loader:981:32)←[39m
←[90m    at Function.Module._load (node:internal/modules/cjs/loader:822:12)←[39m
←[90m    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)←[39m {
  code: ←[32m'MODULE_NOT_FOUND'←[39m,
  requireStack: [ ←[32m'c:\\reactor\\tools\\install_reactor_windows_service.js'←[39m ]
}

[toggledbits]

I built a bare-metal only build 22238; download that and try it. Follow the instructions exactly. Do not run npm audit on Windows, you'll break the node-windows package and the service will not be installed. You must use exactly the version specified in the installation instructions right now.

[Andr]

@toggledbits said in Update from 22240 to 22310 failed. New Install also failed. (Windows):

I built a bare-metal only build 22238; download that and try it. Follow the instructions exactly. Do not run npm audit on Windows, you'll break the node-windows package and the service will not be installed. You must use exactly the version specified in the installation instructions right now.

Yes, that fixed it!
Awesome support as always!

[tunnus]

@toggledbits, 22310 release notes are missing from the announcements?