Reactor build 26116: empty group reaction

[therealdb]

I have a couple of rules that has group reactions with empty conditions. I notice, in particular on one that's called every 5 secs, that it was not working. I added an empty comment as condition and it started working again.

I don't know if saving was enough to "reset" it, but I'm reporting anyway. No errors in the logs, but the MQTT message was not published, so I had an easy path to check the rule.

I have others like these, but not easy to test. @toggledbits maybe some stuck status data? (I restarted a couple of times after the last update). Thanks.

[therealdb]

Yes, I confirm the problem. I had to add a comment to a couple of empty groups.

[toggledbits]

OK. Here's the release note I'm making on this for the next build:

• The behavior of empty "group" conditions was changed in error. As of the next build, the behavior is as follows: group actions may have empty constraints (no conditions), and since this is not explicitly false, the group will be allowed to run; while actions may not have empty constraints (and this will be enforced by the UI/editor going forward), and if a legacy while action is encountered with no conditions, it will not execute (safe behavior). A disabled group or while action will not run.

[gwp1]

@toggledbits how does this pertain to rulesets that have Groups in Set Reaction for different "scenarios", if you will.

Example:

I'm asking because this ruleset stopped working with 26116 and I'm so strapped on personal time atm that I just broke it out into three sep rulesets and each works correctly.

[toggledbits]

@gwp1 unrelated.

[gwp1]

@toggledbits

I'll try to find a few minutes to grab logs. I gave a quick look and saw nothing screaming.

[toggledbits]

@gwp1 Logs probably long gone if you've already modified the reaction. It would help to see the group in its original form, though.

[gwp1]

@toggledbits I still have the ruleset, just disabled. Easy enough to disable the temporary ones and re-enable this one and try to trigger it. (I had a smart moment!)

[therealdb]

@toggledbits fair enough. I’ve analyzed more than 100 rules and I fixed a bunch of them manually. I’ll update my second system with next build.

Thanks!