OpenAI Controller for Reactor

[toggledbits]

@cw-kid said in Having issues with a shell command:

I'm not sure, I will look out for when it happens again.

The goal I propose is to write a script that runs ps4-waker itself, and retries if it fails to connect. MSR would then run that script instead of running ps4-waker directly. If, for example, the ps4-waker script simply returns no data (empty) result, then something like this would work:

#!/bin/sh

while true; do
    # Run command and capture its output and exit status
    output=`ps4-waker $*`
    status=$?
    # If output was produced, stop looping.
    if [ -n "$output" ]; then
        break;
    fi
    sleep 1 # slow retries down a little
done
# Echo back the command output and exit with its exit status.
echo "$output"
exit $status

Save this as ps4-wrapper.sh in the Reactor install directory (or somewhere along the path, like where ps4-waker currently is), and give it execute permissions (chmod 755 ps4-wrapper.sh).

The wrapper script can be run in place of ps4-waker, with the same arguments (e.g. ps4-wrapper.sh status). If a request fails and produces no output, it is simply re-run until output is produced (or until the command times out in Reactor, when it is killed).

[toggledbits]

@cw-kid said in Having issues with a shell command:

Maybe one rule hi-jacks the other from triggering sometimes ?

No, each rule has its own supervision of its entities of interest, etc. You'd be able to quickly confirm this by looking in the logs and seeing that the SET reactions for both rules run.

[cw-kid]

@toggledbits said in Having issues with a shell command:

The goal I propose is to write a script

Great thanks I will try this approach instead then.

But first I will leave things as is and see what happens? when it doesn't turn on the PS4 on first attempt.

It might just return no data in the response as you suggest, or it may as I seem to think, return something else, which I haven't documented here in this thread yet. But I can't remember off the top of my head what it was doing.

[cw-kid]

This isn't related to when the PS4 doesn't turn on.

When the PS4 is OFF / sleep mode, I am seeing this error alert appearing, to do with the parsing of the output to JSON.

I assume this alert occurs if the "ps4-waker check" command hasn't worked and initially pulled in the data ?

Maybe I need two wrapper scripts then, one for turning on the power and one for the check command also.

[cw-kid]

Regarding the power on issue and maybe using a wrapper script.

When I manually run the "ps4-waker" command in terminal this is the output I get back:

 WAKEUP sent to device... 192.168.0.201

I don't see any alert in MSR gui when it fails to turn on the PS4 on its first and currently only attempt to do so.

Looking in the log I can't see anything there either as to why the command didn't turn on the PS4 ?

2021-08-04T13:08:32.530Z <Rule:5:Rule.js:660> Rule#rule-krpft5eh rule set variable ps4waker = (string) 
2021-08-04T13:08:32.533Z <Engine:5:Engine.js:945> Engine#1 set variable rule rule-krpft5eh ps4waker=, requesting re-eval
2021-08-04T13:08:32.534Z <Rule:5:Rule.js:956> Rule#rule-krpft5eh (Lounge - Harmony PS4 Activity Start - Wake PS4 Shell Command) evaluate() acquiring mutex
2021-08-04T13:08:32.535Z <Engine:5:Engine.js:1145> _process_reaction_queue() wake-up!
2021-08-04T13:08:32.536Z <Rule:5:Rule.js:960> Rule#rule-krpft5eh._evaluate() mutex acquired, evaluating
2021-08-04T13:08:32.537Z <Rule:5:Rule.js:964> Rule#rule-krpft5eh update rate is 6/min limit 60/min
2021-08-04T13:08:32.537Z <Rule:5:Rule.js:887> Rule#rule-krpft5eh evaluateExpressions() with 1 expressions
2021-08-04T13:08:32.538Z <Rule:5:Rule.js:976> Rule#rule-krpft5eh._evaluate() trigger state now true (was true)
2021-08-04T13:08:32.539Z <Rule:5:Rule.js:978> Rule#rule-krpft5eh._evaluate() constraints state true
2021-08-04T13:08:32.540Z <Rule:5:Rule.js:987> Rule#rule-krpft5eh rule state now true, changed no
2021-08-04T13:08:32.541Z <Engine:5:Engine.js:1106> _process_reaction_queue() running task 2261 { "tid": 2261, "id": "rule-krpft5eh:S", "rule": "rule-krpft5eh", "__reaction": [RuleReaction#rule-krpft5eh:S], "next_step": 3, "status": 1, "ts": 1628082499978, "parent": --null--, "__resolve": --function--, "__reject": --function--, "__promise": [object Promise], "attempts": 2 }
2021-08-04T13:08:32.542Z <Engine:NOTICE> Resuming reaction Lounge - Harmony PS4 Activity Start - Wake PS4 Shell Command<SET> (rule-krpft5eh:S) from step 3
2021-08-04T13:08:32.542Z <Engine:INFO> Lounge - Harmony PS4 Activity Start - Wake PS4 Shell Command<SET> all actions completed.
2021-08-04T13:08:32.543Z <Engine:5:Engine.js:1110> _process_reaction_queue() task returned, new status -1; task 2261
2021-08-04T13:08:32.545Z <Engine:5:Engine.js:1145> _process_reaction_queue ending with 0 in queue; none delayed/ready; waiting
2021-08-04T13:08:32.832Z <Rule:5:Rule.js:748> Rule#rule-knn2os0h dependency notification entity-changed Entity#vera>device_184 from Entity#vera>device_184
2021-08-04T13:08:32.834Z <Rule:5:Rule.js:754> Rule#rule-knn2os0h requesting eval; entity-changed Entity#vera>device_184
2021-08-04T13:08:32.836Z <Rule:5:Rule.js:748> Rule#rule-klkppx0h dependency notification entity-changed Entity#vera>device_184 from Entity#vera>device_184
2021-08-04T13:08:32.837Z <Rule:5:Rule.js:754> Rule#rule-klkppx0h requesting eval; entity-changed Entity#vera>device_184
2021-08-04T13:08:32.838Z <Rule:5:Rule.js:748> Rule#rule-krpft5eh dependency notification entity-changed Entity#vera>device_184 from Entity#vera>device_184
2021-08-04T13:08:32.839Z <Rule:5:Rule.js:754> Rule#rule-krpft5eh requesting eval; entity-changed Entity#vera>device_184
2021-08-04T13:08:32.839Z <Rule:5:Rule.js:956> Rule#rule-knn2os0h (Lounge - Harmony XBOX Activity Start - Close Window Coverings (Day)) evaluate() acquiring mutex
2021-08-04T13:08:32.840Z <Rule:5:Rule.js:956> Rule#rule-klkppx0h (Lounge - Harmony Powered OFF - Turn OFF LED strips) evaluate() acquiring mutex
2021-08-04T13:08:32.841Z <Rule:5:Rule.js:956> Rule#rule-krpft5eh (Lounge - Harmony PS4 Activity Start - Wake PS4 Shell Command) evaluate() acquiring mutex
2021-08-04T13:08:32.841Z <Rule:5:Rule.js:960> Rule#rule-knn2os0h._evaluate() mutex acquired, evaluating
2021-08-04T13:08:32.842Z <Rule:5:Rule.js:964> Rule#rule-knn2os0h update rate is 6/min limit 60/min
2021-08-04T13:08:32.843Z <Rule:5:Rule.js:887> Rule#rule-knn2os0h evaluateExpressions() with 0 expressions
2021-08-04T13:08:32.844Z <Rule:5:Rule.js:976> Rule#rule-knn2os0h._evaluate() trigger state now false (was false)
2021-08-04T13:08:32.846Z <Rule:5:Rule.js:978> Rule#rule-knn2os0h._evaluate() constraints state false
2021-08-04T13:08:32.847Z <Rule:5:Rule.js:987> Rule#rule-knn2os0h rule state now false, changed no
2021-08-04T13:08:32.847Z <Rule:5:Rule.js:960> Rule#rule-klkppx0h._evaluate() mutex acquired, evaluating
2021-08-04T13:08:32.848Z <Rule:5:Rule.js:964> Rule#rule-klkppx0h update rate is 6/min limit 60/min
2021-08-04T13:08:32.848Z <Rule:5:Rule.js:887> Rule#rule-klkppx0h evaluateExpressions() with 0 expressions
2021-08-04T13:08:32.849Z <Rule:5:Rule.js:976> Rule#rule-klkppx0h._evaluate() trigger state now true (was true)
2021-08-04T13:08:32.850Z <Rule:5:Rule.js:978> Rule#rule-klkppx0h._evaluate() constraints state false
2021-08-04T13:08:32.851Z <Rule:5:Rule.js:987> Rule#rule-klkppx0h rule state now false, changed no
2021-08-04T13:08:32.851Z <Rule:5:Rule.js:960> Rule#rule-krpft5eh._evaluate() mutex acquired, evaluating
2021-08-04T13:08:32.852Z <Rule:5:Rule.js:964> Rule#rule-krpft5eh update rate is 7/min limit 60/min
2021-08-04T13:08:32.853Z <Rule:5:Rule.js:887> Rule#rule-krpft5eh evaluateExpressions() with 1 expressions
2021-08-04T13:08:32.854Z <Rule:5:Rule.js:976> Rule#rule-krpft5eh._evaluate() trigger state now true (was true)
2021-08-04T13:08:32.854Z <Rule:5:Rule.js:978> Rule#rule-krpft5eh._evaluate() constraints state true
2021-08-04T13:08:32.856Z <Rule:5:Rule.js:987> Rule#rule-krpft5eh rule state now true, changed no
2021-08-04T13:08:33.082Z <Rule:5:Rule.js:748> Rule#rule-knn2os0h dependency notification entity-changed Entity#vera>device_184 from Entity#vera>device_184
2021-08-04T13:08:33.083Z <Rule:5:Rule.js:754> Rule#rule-knn2os0h requesting eval; entity-changed Entity#vera>device_184
2021-08-04T13:08:33.084Z <Rule:5:Rule.js:748> Rule#rule-klkppx0h dependency notification entity-changed Entity#vera>device_184 from Entity#vera>device_184
2021-08-04T13:08:33.085Z <Rule:5:Rule.js:754> Rule#rule-klkppx0h requesting eval; entity-changed Entity#vera>device_184
2021-08-04T13:08:33.086Z <Rule:5:Rule.js:748> Rule#rule-krpft5eh dependency notification entity-changed Entity#vera>device_184 from Entity#vera>device_184
2021-08-04T13:08:33.087Z <Rule:5:Rule.js:754> Rule#rule-krpft5eh requesting eval; entity-changed Entity#vera>device_184
2021-08-04T13:08:33.088Z <Rule:5:Rule.js:956> Rule#rule-knn2os0h (Lounge - Harmony XBOX Activity Start - Close Window Coverings (Day)) evaluate() acquiring mutex
2021-08-04T13:08:33.089Z <Rule:5:Rule.js:956> Rule#rule-klkppx0h (Lounge - Harmony Powered OFF - Turn OFF LED strips) evaluate() acquiring mutex
2021-08-04T13:08:33.090Z <Rule:5:Rule.js:956> Rule#rule-krpft5eh (Lounge - Harmony PS4 Activity Start - Wake PS4 Shell Command) evaluate() acquiring mutex
2021-08-04T13:08:33.090Z <Rule:5:Rule.js:960> Rule#rule-knn2os0h._evaluate() mutex acquired, evaluating
2021-08-04T13:08:33.091Z <Rule:5:Rule.js:964> Rule#rule-knn2os0h update rate is 7/min limit 60/min
2021-08-04T13:08:33.091Z <Rule:5:Rule.js:887> Rule#rule-knn2os0h evaluateExpressions() with 0 expressions
2021-08-04T13:08:33.092Z <Rule:5:Rule.js:976> Rule#rule-knn2os0h._evaluate() trigger state now false (was false)
2021-08-04T13:08:33.093Z <Rule:5:Rule.js:978> Rule#rule-knn2os0h._evaluate() constraints state false
2021-08-04T13:08:33.094Z <Rule:5:Rule.js:987> Rule#rule-knn2os0h rule state now false, changed no
2021-08-04T13:08:33.095Z <Rule:5:Rule.js:960> Rule#rule-klkppx0h._evaluate() mutex acquired, evaluating
2021-08-04T13:08:33.095Z <Rule:5:Rule.js:964> Rule#rule-klkppx0h update rate is 7/min limit 60/min
2021-08-04T13:08:33.096Z <Rule:5:Rule.js:887> Rule#rule-klkppx0h evaluateExpressions() with 0 expressions
2021-08-04T13:08:33.097Z <Rule:5:Rule.js:1595> cond cond58zlosr evaluation state true->false
2021-08-04T13:08:33.098Z <Rule:5:Rule.js:1595> cond trig evaluation state true->false
2021-08-04T13:08:33.098Z <Rule:5:Rule.js:976> Rule#rule-klkppx0h._evaluate() trigger state now false (was true)
2021-08-04T13:08:33.099Z <Rule:5:Rule.js:978> Rule#rule-klkppx0h._evaluate() constraints state false
2021-08-04T13:08:33.100Z <Rule:5:Rule.js:984> Rule#rule-klkppx0h trigger conditions not met
2021-08-04T13:08:33.100Z <Rule:5:Rule.js:987> Rule#rule-klkppx0h rule state now false, changed no
2021-08-04T13:08:33.102Z <Rule:5:Rule.js:960> Rule#rule-krpft5eh._evaluate() mutex acquired, evaluating
2021-08-04T13:08:33.103Z <Rule:5:Rule.js:964> Rule#rule-krpft5eh update rate is 8/min limit 60/min
2021-08-04T13:08:33.103Z <Rule:5:Rule.js:887> Rule#rule-krpft5eh evaluateExpressions() with 1 expressions
2021-08-04T13:08:33.104Z <Rule:5:Rule.js:976> Rule#rule-krpft5eh._evaluate() trigger state now true (was true)
2021-08-04T13:08:33.105Z <Rule:5:Rule.js:978> Rule#rule-krpft5eh._evaluate() constraints state true
2021-08-04T13:08:33.105Z <Rule:5:Rule.js:987> Rule#rule-krpft5eh rule state now true, changed no

I will try and implement the script now.

[cw-kid]

@toggledbits

I've created the ps4-wrapper.sh file and made it executable and placed it in to the Reactor root directory as I cannot find where the actual ps4-waker utility is installed / located on the system.

When I try to run the script in terminal I get errors:

root@HP-Thin01:/home/stuart/reactor# bash ps4-wrapper.sh
ps4-wrapper.sh: line 15: syntax error: unexpected end of file
root@HP-Thin01:/home/stuart/reactor# sh ps4-wrapper.sh
ps4-wrapper.sh: 14: ps4-wrapper.sh: Syntax error: end of file unexpected (expecting "then")
root@HP-Thin01:/home/stuart/reactor#

Also how do I modify the MSR rules to run the script instead of the command directly ?

I tried this:

Thanks

EDIT:

Seems it didn't like me creating the script in Notepad++ on Windows and copying it over to the Debian machine.

So I deleted the script and created it again using nano editor on Debian and now I can run the script OK from the terminal window and the PS4 did turn ON.

However I cannot run the script from the MSR rule still, nothing seems to happen when I play the reaction.

I can't see any errors related to ps4-wrapper.sh

2021-08-04T14:14:30.725Z <Engine:5:Engine.js:1145> _process_reaction_queue() wake-up!
2021-08-04T14:14:30.731Z <Engine:5:Engine.js:1106> _process_reaction_queue() running task 2373 { "tid": 2373, "id": "rule-krpft5eh:S", "rule": "rule-krpft5eh", "__reaction": [RuleReaction#rule-krpft5eh:S], "next_step": 1, "status": 0, "ts": 1628086468720, "parent": --null--, "__resolve": --function--, "__reject": --function--, "__promise": [object Promise], "attempts": 1 }
2021-08-04T14:14:30.731Z <Engine:NOTICE> Resuming reaction Lounge - Harmony PS4 Activity Start - Wake PS4 Shell Command<SET> (rule-krpft5eh:S) from step 1
2021-08-04T14:14:30.732Z <Engine:INFO> Engine#1 reaction Lounge - Harmony PS4 Activity Start - Wake PS4 Shell Command<SET> (rule-krpft5eh:S) step 2 shell command: ps4-wrapper.sh
2021-08-04T14:14:30.733Z <Engine:5:Engine.js:1382> Engine#1 action data { "command": "ps4-wrapper.sh", "rule": "rule-krpft5eh", "rvar": "ps4waker", "ignore_exit": true }
2021-08-04T14:14:30.749Z <Engine:5:Engine.js:1110> _process_reaction_queue() task returned, new status 3; task 2373
2021-08-04T14:14:30.751Z <Engine:5:Engine.js:1145> _process_reaction_queue ending with 1 in queue; none delayed/ready; waiting
2021-08-04T14:14:30.755Z <Rule:5:Rule.js:660> Rule#rule-krpft5eh rule set variable ps4waker = (string) 
2021-08-04T14:14:30.755Z <Engine:5:Engine.js:945> Engine#1 set variable rule rule-krpft5eh ps4waker=, requesting re-eval
2021-08-04T14:14:30.756Z <Rule:5:Rule.js:956> Rule#rule-krpft5eh (Lounge - Harmony PS4 Activity Start - Wake PS4 Shell Command) evaluate() acquiring mutex
2021-08-04T14:14:30.757Z <Engine:5:Engine.js:1145> _process_reaction_queue() wake-up!
2021-08-04T14:14:30.758Z <Rule:5:Rule.js:960> Rule#rule-krpft5eh._evaluate() mutex acquired, evaluating
2021-08-04T14:14:30.758Z <Rule:5:Rule.js:964> Rule#rule-krpft5eh update rate is 1/min limit 60/min
2021-08-04T14:14:30.759Z <Rule:5:Rule.js:887> Rule#rule-krpft5eh evaluateExpressions() with 1 expressions
2021-08-04T14:14:30.760Z <Rule:5:Rule.js:976> Rule#rule-krpft5eh._evaluate() trigger state now true (was true)
2021-08-04T14:14:30.761Z <Rule:5:Rule.js:978> Rule#rule-krpft5eh._evaluate() constraints state true
2021-08-04T14:14:30.762Z <Rule:5:Rule.js:987> Rule#rule-krpft5eh rule state now true, changed no
2021-08-04T14:14:30.763Z <Engine:5:Engine.js:1106> _process_reaction_queue() running task 2373 { "tid": 2373, "id": "rule-krpft5eh:S", "rule": "rule-krpft5eh", "__reaction": [RuleReaction#rule-krpft5eh:S], "next_step": 3, "status": 1, "ts": 1628086468720, "parent": --null--, "__resolve": --function--, "__reject": --function--, "__promise": [object Promise], "attempts": 2 }
2021-08-04T14:14:30.764Z <Engine:NOTICE> Resuming reaction Lounge - Harmony PS4 Activity Start - Wake PS4 Shell Command<SET> (rule-krpft5eh:S) from step 3
2021-08-04T14:14:30.764Z <Engine:INFO> Lounge - Harmony PS4 Activity Start - Wake PS4 Shell Command<SET> all actions completed.
2021-08-04T14:14:30.765Z <Engine:5:Engine.js:1110> _process_reaction_queue() task returned, new status -1; task 2373
2021-08-04T14:14:30.767Z <Engine:5:Engine.js:1145> _process_reaction_queue ending with 0 in queue; none delayed/ready; waiting
2021-08-04T14:14:34.579Z <EzloController:5:EzloController.js:1069> EzloController#ezlo-plus received message 485 bytes

Just seen an unrelated error in the logs

<EzloController:ERR> EzloController#ezlo-plus no implementation mapping for attributes from match * cap x_ezlo_object

[toggledbits]

When you create the file on Windows in Notepad++, it will get Windows line endings (CR+LF) instead of Unix line endings (LF alone) and that confuses the shell. You can select the right line endings under the Edit > EOL Conversion in Notepad++.

If you modified the ps4-waker command to be anything other than ps4-waker $* put it back the way I gave it to you. That lets you run the wrapper script with arguments on the command line that will get passed through, like this: ./ps4-wrapper.sh status or ./ps4-wrapper.sh somethingelse

In the MSR rule, you should use /full/path/to/ps4-wrapper.sh arguments

[cw-kid]

@toggledbits said in Having issues with a shell command:

When you create the file on Windows in Notepad++, it will get Windows line endings (CR+LF) instead of Unix line endings (LF alone) and that confuses the shell. You can select the right line endings under the Edit > EOL Conversion in Notepad++.

Top tip thanks, I have changed that setting now in Notepad++

[cw-kid]

@toggledbits said in Having issues with a shell command:

If you modified the ps4-waker command to be anything other than ps4-waker $* put it back the way I gave it to you. That lets you run the wrapper script with arguments on the command line that will get passed through, like this: ./ps4-wrapper.sh status or ./ps4-wrapper.sh somethingelse

I haven't change the script, that line still says

output=`ps4-waker $*

In the terminal I can use this command and it works and outputs the response

sh ps4-wrapper.sh check

So the argument is passed OK.

I can also just run this command which turns on the PS4

sh ps4-wrapper.sh

There is no argument for the command for turning on the PS4 as the command is just

ps4-waker

So maybe this is the problem?

However I am unsure how to run the .sh file from my MSR rules?

Thanks

[toggledbits]

Best way is to use /full/path/to/ps4-wrapper.sh arguments, but you may also get away with ./ps4-wrapper.sh arguments if it's in the Reactor install directory. Remember to set the file permissions for read and execute.

[cw-kid]

@toggledbits said in Having issues with a shell command:

./ps4-wrapper.sh

Seems to do the trick, the PS4 now turns on when this rules trigger happens, which is the Harmony Activity Starting.

I will modify the other rules now to use the wrapper script instead of issuing the commands directly.

Thanks again.

[toggledbits]

Excellent. If you've got a backup script running that takes care of just your config and storage, remember to add your wrapper script to its list of things to copy, since it's not in one of those directories.

[cw-kid]

@toggledbits said in Having issues with a shell command:

If you've got a backup script running that takes care of just your config and storage

I haven't got one, but I could really do with having a backup script running to copy those folders off the HP Thin Client to maybe my Windows file server or something. Or maybe even to a USB stick in the Thin Client if I can find a spare one big enough.

[cw-kid]

oh did you see that Ezlo error I mentioned also?

<EzloController:ERR> EzloController#ezlo-plus no implementation mapping for attributes from match * cap x_ezlo_object

[toggledbits]

Those directories don't get very large, so a network copy is fine and will go fast. I distrust USB sticks, especially when left in devices, as they often have poor thermal management (not built to be left inserted full time) and degrade quickly like that, with little or no warning. Your backup media should be as reliable as possible.

Ezlo error is benign. I'll quiet it down.

[cw-kid]

@toggledbits said in Having issues with a shell command:

Those directories don't get very large

I've just checked:

Storage = 1.08MB

Config = 20.4KB

So yeah pretty small.

I will have to do some Googling how to create a script and schedule it to run, to copy the folders and files to my Windows server, as I have no idea how to do it under Debian terminal.

There is no desktop on that HP Thin Client running MSR.

in fact an inbuilt backup feature in MSR would be nice to have.

[toggledbits]

@cw-kid said in Having issues with a shell command:

in fact an inbuilt backup feature in MSR would be nice to have.

I'll think about it, but my thoughts on it so far aren't leaning towards it.

It would have to be cross-platform (Windows, any flavor of Linux you can imagine including Macs, etc.), and to be at all effective, be able to store the backup somewhere other than the place it's backing up... a separate local volume? Windows server? NAS? An NFS share on a Linux server? SCP? FTP? RSYNC? HTTP PUT/POST?... so many options. Reliable backup depends on the local environment quite heavily, and your local knowledge of it and the risks you identify. Unlike Vera, this isn't a contained problem for a canned solution on proprietary hardware and software supported by a controlled cloud. And then, of course, people are going to want a one-click restore, and maybe even partial restore.

Maybe someday there will be backup, but for the moment, it's not a priority and anything I do is all but guaranteed to be a large effort that yields an inadequate result.

[cw-kid]

@toggledbits

Yes I understand what you are saying and there could be many different ways to skin that cat.

But how about a more universal option? Most people will have a Google Drive or Microsoft One Drive cloud storage with their user accounts.

Could a backup option be added to upload to those types of cloud storage services?

[cw-kid]

Everything appears to all be working nicely now.

The only issue is sometimes I see this error alert

I assume it happens when the "ps4wakercheck" variable hasn't been populated with any data and therefore the "ps4wakerparse" variable has nothing to parse.

The ps4waker check rule is now using the wrapper script also, so if for whatever reason it didn't get data returned on its first attempt, it does on the second or subsequent attempts.