[Reactor] Bug when sending MQTT boolean payloads

[Elcid]

Just updated to latest 21294, ran usual update, It appears to start ok in console, but will not load in browser. The NODE_path looks correct but the console log show the below error.

log

NODE_PATH /data/data/com.termux/files/home/reactor:
[latest-21294]2021-10-23T15:55:41.542Z <app:null> Reactor latest-21294-c13ea5d starting on v14.15.4
[latest-21294]2021-10-23T15:55:41.546Z <app:INFO> Process ID 14540; platform android/arm #1 SMP PREEMPT Wed Jan 16 09:21:08 CST 2019; locale en_US.UTF-8
[latest-21294]2021-10-23T15:55:41.547Z <app:INFO> Basedir /data/data/com.termux/files/home/reactor; data in /data/data/com.termux/files/home/reactor/storage
[latest-21294]2021-10-23T15:55:41.548Z <app:INFO> NODE_PATH /data/data/com.termux/files/home/reactor:
/data/data/com.termux/files/home/reactor/app.js:231
        throw new Error(a0_0x4c6635(0xd9) + process[a0_0x4c6635(0xdb)][a0_0x4c6635(0x107)] + '\x20does\x20not\x20point\x20to\x20the\x20Reactor\x20install\x20directory');
        ^

Error: Environment NODE_PATH=/data/data/com.termux/files/home/reactor: does not point to the Reactor install directory
    at Object.<anonymous> (/data/data/com.termux/files/home/reactor/app.js:231:15)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
    at internal/main/run_main_module.js:17:47
NODE_PATH /data/data/com.termux/files/home/reactor:
[latest-21294]2021-10-23T15:55:41.796Z <app:null> Reactor latest-21294-c13ea5d starting on v14.15.4
[latest-21294]2021-10-23T15:55:41.800Z <app:INFO> Process ID 14547; platform android/arm #1 SMP PREEMPT Wed Jan 16 09:21:08 CST 2019; locale en_US.UTF-8
[latest-21294]2021-10-23T15:55:41.801Z <app:INFO> Basedir /data/data/com.termux/files/home/reactor; data in /data/data/com.termux/files/home/reactor/storage
[latest-21294]2021-10-23T15:55:41.801Z <app:INFO> NODE_PATH /data/data/com.termux/files/home/reactor:
/data/data/com.termux/files/home/reactor/app.js:231
        throw new Error(a0_0x4c6635(0xd9) + process[a0_0x4c6635(0xdb)][a0_0x4c6635(0x107)] + '\x20does\x20not\x20point\x20to\x20the\x20Reactor\x20install\x20directory');
        ^
```===group
```java

===

[toggledbits]

That suggests that server/lib/Logger.js cannot be found under the directory given. Make sure your unzip and copy of the files from the distribution is complete.

Edit: looking more carefully at it, it appears that the ':' at the end of the path in NODE_PATH is not from the messages, but is actually in the path. That's an error.

[Elcid]

server/lib/Logger.js is there in the reactor folder
I can start reactor with NODE_PATH=$(pwd) node app.js and see it in browser
but using nohup ./app.sh & i can not open reactor in browser

app,sh

#!/bin/bash

WD="."
if [ "$1" == "-C" ]; then
	WD=${2:-.}
	shift 2
fi
WD=`realpath "${WD}"`

cd $WD || exit 1
export NODE_PATH="${WD}:${NODE_PATH}"
rm -f app.stop
while [ ! -f app.stop ]; do
	node app.js $* >> logs/console.log 2>&1
	[ $? -eq 127 ] && break;
	sleep 5
done

exit 0

is the : in line 11 the error?

[Elcid]

ok i removed :${NODE_PATH} from app.sh on line 11 and now it starts and shows in browser using nohup ./app.sh &

[toggledbits]

I've had app.sh on my deprecation list for some time, so I don't use it or test with it. I may review that choice.

[Elcid]

That's how i start MSR on my android system, then the console is clear and usable. How would you suggest I start it now under termux?

[toggledbits]

Stay with what you've got. Clearly, we're not ready for app.sh to go away. I've improved the checks on NODE_PATH in the startup to prevent the error caused by the path separator and empty path, so the stock (unmodified) app.sh should work fine now. That change is in build 21297 just released.

[Elcid]

just confirming 21297 working with original app.sh