Reactor-Editor / Reactor-ui-Status Errors

[kfxo]

@tarkus said in Running Lua Code ? And watching device properties?:

In preliminary testing the big issue I see with lua in Vera scenes is stability. I tried moving some of my lua into scenes and invoking the scenes thru MSR and everything just became real unstable with Luup restarts.

I think you already discovered the problem. Running the lua through scenes is probably not a good idea. Have you attempted what was suggested by @therealdb in this thread defining a library at startup and calling your lua through that? IMO this is the correct way to do it.

[toggledbits]

@cw-kid said in Running Lua Code ? And watching device properties?:

VeraController:ERR [VeraController:performOnEntity] action request failed
VeraController:CRIT Error: Request failed: 401 Error

Have you looked at the Vera log corresponding to the time to see what it's logging? Also what happens when you run it via the Vera UI?

[Tarkus]

@kfxo I did scan thru that approach. I will definitely try to implement this before proceeding with anything else. Thanks

[cw-kid]

@toggledbits

luvd_get_info_data_request starting /data_request?SceneNum=null&DeviceNum=86&id=action&serviceId=urn%3Amicasaverde-com%3AserviceId%3AHomeAutomationGateway1&action=RunScene&output_format=json&_r=1614868227818 pMem 0x3473000/54996992 diff: 39190528 <0x6cd27520>
08	03/04/21 14:30:27.829	JobHandler_LuaUPnP::HandleActionRequest device: 0 service: urn:micasaverde-com:serviceId:HomeAutomationGateway1 action: RunScene <0x6cd27520>
08	03/04/21 14:30:27.829	JobHandler_LuaUPnP::HandleActionRequest argument SceneNum=null <0x6cd27520>
08	03/04/21 14:30:27.829	JobHandler_LuaUPnP::HandleActionRequest argument DeviceNum=86 <0x6cd27520>
08	03/04/21 14:30:27.830	JobHandler_LuaUPnP::HandleActionRequest argument serviceId=urn:micasaverde-com:serviceId:HomeAutomationGateway1 <0x6cd27520>
08	03/04/21 14:30:27.830	JobHandler_LuaUPnP::HandleActionRequest argument action=RunScene <0x6cd27520>
08	03/04/21 14:30:27.831	JobHandler_LuaUPnP::HandleActionRequest argument _r=1614868227818 <0x6cd27520>
02	03/04/21 14:30:27.831	JobHandler_LuaUPnP::RunAction device -1 action urn:micasaverde-com:serviceId:HomeAutomationGateway1/RunScene failed with 401/Invalid Scene <0x6cd27520>

Strange it says its an invalid scene.

"Fan On" is scene number 86 in Vera and that is the scene I selected to run in my "Set Reaction" run script.

If I run the "Fan On" scene actually in Vera on the UI7 web GUI it works the scene runs OK.

Why does it have a device number and scene number is null ?

SceneNum=null&DeviceNum=86

[cw-kid]

@Tarkus

John, what version of MSR are you currently running? 0.1.21062 ?

Thanks

[toggledbits]

@tarkus That helps. Open a PR. The scene ID isn't being passed correctly. That's a quick fix you can do in place in a minute. I'll post what you need on the PR.

[cw-kid]

@toggledbits said in Running Lua Code ? And watching device properties?:

The scene ID isn't being passed correctly

You talking to me ?

There is a PR open already.

https://reactor.toggledbits.com/mantisbt/view.php?id=80

[Tarkus]

@cw-kid yes 0.1.21062 but it seems that my scenes are not getting invoked by MSR today as well. I did test when I initially installed the other day and they did work.

[cw-kid]

@tarkus Right I see, we are both in the same boat then. Its a bug on todays MSR build.

Fingers crossed for a hot fix !

[toggledbits]

Both, and yes, I see the PR. I hadn't looked at my email or Mantis yet this morning, still getting off the ground here, so I didn't see it get opened. All good and thank you. Discussion on that thread shortly.

[toggledbits]

FYI, I'm also trying to implement the "run lua" action for the (vera-specific) system device. That does not mean Lua will run in MSR -- it does not, can not, and will not. But Vera does give me the ability to pass it Lua and have it execute it. That fills me with dread, frankly, but if it's what you need, it can be done. It will also need a UI change to support it, since typing Lua into a small entry field won't due. If it works, it should make invoking functions in a Lua module (built as @therealdb has shown you to do) pretty easy.

[toggledbits]

Update, if you haven't already been notified by Mantis: patch is up on PR#80.

[cw-kid]

@toggledbits said in Running Lua Code ? And watching device properties?:

FYI, I'm also trying to implement the "run lua" action for the (vera-specific) system device. That does not mean Lua will run in MSR -- it does not, can not, and will not. But Vera does give me the ability to pass it Lua and have it execute it. That fills me with dread, frankly, but if it's what you need, it can be done. It will also need a UI change to support it, since typing Lua into a small entry field won't due. If it works, it should make invoking functions in a Lua module (built as @therealdb has shown you to do) pretty easy.

I'm sure this will be very handy for some users.

I am good at the moment however, using the method therealdb showed me. Its working currently.

[cw-kid]

@toggledbits said in Running Lua Code ? And watching device properties?:

Update, if you haven't already been notified by Mantis: patch is up on PR#80.

Confirmed as working again thanks.

[toggledbits]

@tarkus said in Running Lua Code ? And watching device properties?:

I now am trying the CG plugin that Patrick sorted out for me. The small issue with that is I need to convert all my Global Cache codes to pronto hex. I only mention so others know it does not support CG codes.

Were you not using the GC100 plugin before? Because if you were, it should not work any differently through MSR. MSR only passes the string in whatever format. If GC100 understood other code types before (even though the action has "Pronto" in the name), it would still now. MSR doesn't modify or interpret that data.

[Tarkus]

@toggledbits No I was using Lua in Vera Reactor to pass the Global Cache codes. I have played around with the GC Plugin in the past but I have not used it in years up until MSR.

[toggledbits]

@cw-kid said in Running Lua Code ? And watching device properties?:

I am good at the moment however, using the method therealdb showed me. Its working currently.

I think you're missing what I'm saying. You don't need change your library structure or not do what @therealdb has suggested. It's a good, clean way to go. But if you do this from MSR right now as a Request action (that's what I assume you are doing) to run the function:

http://ip-address:3480/data_request?id=lu_action&serviceId=urn:micasaverde-com:serviceId:HomeAutomationGateway1&action=RunLua&Code=VeraScenes.turnLightsOn%28nil%29

You can (21063 and after) just do this, assuming you've loaded the library in startup Lua:

And if you haven't loaded it in startup Lua, you can just bring it in with the code, like this:

[kfxo]

@toggledbits This looks great. So much easier then having to write out the http request.

[Tarkus]

This post is deleted!

[cw-kid]

@toggledbits

I thought you meant we could actually put the LUA code itself in to a MSR action "Set Reaction" and some how you were going to pass that to Vera.

But I see what you meant now, so we still need to edit the VeraScenes.lua file and add our functions / LUA code etc.

I can confirm the Play button works and the code is executed on my Vera Plus

So instead of sending a HTTP Request to Vera to initiate the function we can now just specify the function in the MSR rule actions.