Organizing/ structuring rule sets and rules

[LibraSun]

@cw-kid said in Replacing SiteSensor Plugin (Vera) with MSR:

@librasun

I am doing a different http request to Vera to set each variable not one request that set them all.

Yeah, something tells me setting more than one at a time isn't possible, anyway. Just thought I'd ask the pros. Thanks!

[gwp1]

@librasun Reviving this a bit because this right here is where I think I'm failing spectacularly.

I'm working with the Ambient API for my weather station via Site Sensor in Vera. This thread has been fantastic at guiding me toward migrating the Site Sensor into MSR. Here's where I'm falling down:

The GET returns expected results. However, I believe I've messed up in creating the expressions for temp, wind speed, wind gust, and solar radiation.

I've entered response[1].lastData.tempf into the ambient_temp field and it returns Last value:(error) Invalid reference to member 1 of null. This is taken right from the Site Sensor recipe where it's working wonderfully so I know I'm probably close. I know the expression logic in MSR is slightly different than that of the Vera Reactor plugin - combined with my almost total befuddlement of proper expressions go isn't helping

Appreciate any guidance!

[Elcid]

should that be response[0].lastData.tempinf

[gwp1]

I thought the same but, after editing, it returned the same error just with ...member 0 of null instead.

[gwp1]

@elcid For full transparency, here's how the ruleset is configured (and it's pulling in expected results:

It's only the latter half that's making me stumble.

[Elcid]

so to set temp expression should be ambient_api[0].lastData.tempinf

[Elcid]

This post is deleted!

[gwp1]

@elcid Whadya know, that did the trick. Interesting to a noob like me how the original Site Sensor in Vera uses response[1].lastData.tempif and that works just fine.

[gwp1]

@toggledbits QQ on the OWM built-in: is there a means by which to render it inactive until I need to call it? The way I work my Site Sensors is the one for OWM stays deactivated until the one for Ambient throws null at which point the OWM turns on, carrying the load until Ambient throws real data back out there again (at which time OWM shuts back off.)

This saves wasted calls to the API for OWM.

[tunnus]

@gwp1 Put a constraint for the OWM rule, something like "ambient == null"?

[Elcid]

@gwp1 vera uses lua, which arrays count from 1
MSR uses javascript which counts from 0

[gwp1]

@tunnus That would work if I were creating the OWM like I've created the Ambient expressions and ruleset. But @toggledbits has OWM built-in, controlled by reactor.yaml config file. The frequency of calls to the API is configured there in minutes and it creates an entity in the Entities list. As I understand it, the entity is always refreshed data-wise by the frequency of the calls set in reactor.yaml.

[toggledbits]

@gwp1 said in Replacing SiteSensor Plugin (Vera) with MSR:

@toggledbits QQ on the OWM built-in: is there a means by which to render it inactive until I need to call it?

No. Controllers can only be switched on and off via configuration.

[gwp1]

@gwp1I got this all working, Ambient's API and OWM's API all dumping to global expressions.

ambient_api
ambient_temp
ambient_windspeed
ambient_windgust
ambient_solarradiation

openwxmap_api
openwxmap_temp
openwxmap_windspeed
openwxmap_windgust

Everything is glorious. I've planned for when the Ambient API drops (they were having big ol' issues today and into the evening now) it returns a NULL and I flip my HVAC control over to OWM API.

Except... Reactor gets very angry.

Now it's entirely possible this is on me - so let's review:
HVAC has three master rulesets, Cooling, Heating, and Neutral. You'll notice I've broken out the rules into Ambient vs OWM.

The triggers for OWM include a "when Ambient returns NULL" clause, if you will.

These are my two "Site Sensors" in MSR:

This, too, works as intended with OWM sitting idle until Ambient goes "null" and then OWM starts making API calls and populating the global expressions with data.

In real world usage today/this evening the switch happens flawlessly. Where the angry Reactor comes in is after the switch happens. My confusion is around why any ruleset referencing the Ambient data (via global expressions) as a trigger suddenly has all the compile errors, throttling because update rates exceed 60/minute, etc. My expectation is that the "null" will blank the triggers in the ruleset and, since the ruleset is not triggered, it will go dormant until triggered again.

Where have I lost my way?

[tunnus]

@gwp1 I get similar throttling warnings as you do when rules are not able to get values they used to get (via API), but at least you can eliminate those "invalid reference" errors using the following expression structure:

[gwp1]

@tunnus Pardon my ignorance but where do I utilize this structure?

[toggledbits]

I don't recommend using if statements. There are coalescing operators to make the deferencing through the structures easier and tidier when null is a possibility. See the documentation

Also your API Sensor OpenWxMap would be better without the Interval condition and applying pulse output mode (condition options) on the null test.

As for the throttling, I would comb through all of your rules and reactions to see if you have any left-over Set Variable or other actions that would change the value of any of the subject variables. Something seems to be competing with what you've shown here.

[gwp1]

@toggledbits I'm not understanding Pulse vs Interval. That trigger is intended to be how often it queries the API (yes, five minutes is aggressive - I'll pull that back once this is all working.)

There's nothing writing to those variables as they never existed prior to just a day or two ago when I reopened this project of migrating off of Vera's Site Sensors.

Now, there are a slew of rulesets READING from those. That's where my confusion lies, also. In my mind, if it reads the data and it doesn't match the trigger criteria it should just stop until the data changes again, no?

For instance, the Fountain ruleset is complaining. But it's only set to read from Ambient API values - it should be done until there's Ambient data.

[toggledbits]

It's just an alternate way of doing things. I'm not a fan of Interval conditions, and view them as a necessary evil, so I try to remove their use whenever alternate functionality accomplishes the same.

The big problem you have here overall is that, currently, global variables changing does not drive rule evaluations. I think this came up in the other thread. Just because your Ambient fetch rule is updating ambient_api does not mean that ambient_temp is being updated in that same instant (that depends on how you are setting it, which you haven't shown us), and just because ambient_temp changes (no matter how you set it) doesn't mean that "Fountain via Ambient API" suddenly wakes up and checks it. This may simply be a current limitation of global variables as implemented that needs to be reviewed.

Another issue I see here is simply one of structure. If you've got "Fountain via Ambient" and "Fountain via OpenWxMap", then I assert you're making your life harder. It would be better to have a current_temp rule that itself decides if it is going to use Ambient or OpenWxMap, and the "Fountain" rule (singular) has no idea where that data came from and doesn't care.

current_temp = isnull( ambient_api?.whatever?[0] ) ? openwxapi?.whatever?[0].temperature :
    ambient_api.whatever[0].temperature

Also, even if everything operated to your assumptions, you have a race condition. There's an instant while the first OpenWxMap fetch is occurring that the query data from a previous query of hours, days, weeks, or months ago may be used, and that may cause reactions you don't intend until the OpenWxMap fetch succeeds and the data is updated. This is a side-effect of your goal of avoiding continuous OWM calls. There are workarounds, but the issue is moot at this point because the entire thing doesn't work like you think it does.

The implementation decision to not have global variables drive rule evaluation occurred early on. There were issues that prevented it, but since then, the rule evaluation algorithm has changed substantially. I'd need to study and test if this can be changed to work well under the new order. I agree it would be "better" (work more like expected) if rules could respond to global variable changes, but there are many opportunities for logic loops and other issues in doing that, so figuring that out and how to maintain control of the system and give the user meaningful feedback about such errors may not be a small task. (So I'm saying, I won't fix it today. Tomorrow's not looking good either.)

[gwp1]

@toggledbits Firstly, there is no "Fountain via OWM" as it's missing one of the metrics I use to drive that stupid thing.

Secondly - yes, if global variables do not drive rule evaluations then this whole idea is moot. I was hoping to pull Site Sensors out of Vera at long last. It appears, at least taking the path I did, that this is not viable.

Regarding how I have ambient_api set:

That populates the rest of the global expressions:

I need to think thru this some more if Global Expressions will not work as triggers. Has to be a way to present those datapoints as triggers like I've done with the Vera Site Sensors.