Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • Unsolved
Collapse
Discussion Forum to share and further the development of home control and automation, independent of platforms.
  1. Home
  2. Software
  3. Multi-System Reactor
  4. PR #178 In-place modification of arrays in "each"
Gradually turn on lights.
Tom_DT
I have several lights that I would like to turn on very gradually over 15 or 20 seconds. from 0 to .25 in .01 increments. I have tried a few things that came nowhere near working, so here I am.
Multi-System Reactor
Stop the MSR by an external switch on Hubitat.
wmarcolinW
Use case: When performing home maintenance, such as air conditioning, I want all rules involving air conditioning to be disabled. To do this, to day, I have a virtual switch that I placed within all rules involving air conditioning, meaning that if I turn it off, none of them work. Then another situation: the water pump system and garden irrigation, another switch. In short, I had to create several virtual switches in Hubitat to disable rules in MSR. Unfortunately, however, I was unable to cover all scenarios, so I wondered if it would be possible for MSR to support a virtual MSR switch, which, when configured in the reactor settings, would function as a general on/off switch for MSR. If it is configured and turned off, the entire rules and actions in MSR stops working, except for the status change reading process, specifically for this switch, which, when turned on, would restart the MSR. Would it be possible to do something like this? Any recommendations from the experts?
Multi-System Reactor
Error After Upgrade
T
Topic thumbnail image
Multi-System Reactor
Reset attribute value of entity in event handler
R
Topic thumbnail image
Multi-System Reactor
Need help figuring out how to delay a reset on reaction
T
Topic thumbnail image
Multi-System Reactor
Way to search for rules (rule state) in other rules
T
@toggledbits, not sure if this is a feature request or I'm using the search tool wrong. You have a "Search for rule" in the Rules Set tab in MSR. It works nicely to find a rule and bring up said rule, but can it/could it be used for as a "where used?" global search? For instance, I have a fairly large set of rules, divided up into 10 different rulesets. There's easily a hundred individual rules, and many of the rules have Rule State triggers, which of course refer to other rules. Amongst my troubleshooting today, I came across what may have been a duplicate or troubleshooting attempt, but I can't tell if it's actually used as a Rule State in another rule without opening each rule that I suspect it may be a part of. Thanks.
Multi-System Reactor
Links to MSR from HA
Tom_DT
I am using Home Assistant a lot recently. On a dashboard showing the devices, I would like to show a link to the MSR rule that controls the devices. Is there a way to link directly into MSR?
Multi-System Reactor
Set Reaction > Script Action
wmarcolinW
Topic thumbnail image
Multi-System Reactor
Errors after updating to MQTTController build 25139
tunnusT
I'm running MSR build 25139 on Docker, using MQTT controller 24293, and everything working as expected. But if I try to upgrade to MQTTController build 25139, I'm getting the following errors on MSR UI: An Entity Attribute condition in "Lay-Z-Spa auto heating off" (Terrace) failed because the referenced entity "Lay-Z-Spa States" (mqtt>layzspa_states) does not have attribute value_sensor.god Last 11:20:37 An Entity Attribute condition in "Lay-Z-Spa auto heating off" (Terrace) failed because the referenced entity "Lay-Z-Spa States" (mqtt>layzspa_states) does not have attribute temperature_sensor.green Last 11:20:37 An Entity Attribute condition in "Lay-Z-Spa filter pump auto off" (Terrace) failed because the referenced entity "Lay-Z-Spa States" (mqtt>layzspa_states) does not have attribute temperature_sensor.red Last 11:20:37 An Entity Attribute condition in "Lay-Z-Spa filter pump auto run" (Terrace) failed because the referenced entity "Lay-Z-Spa States" (mqtt>layzspa_states) does not have attribute value_sensor.pump Last 11:20:37 An Entity Attribute condition in "Lay-Z-Spa watchdog" (Terrace) failed because the referenced entity "Lay-Z-Spa States" (mqtt>layzspa_states) does not have attribute value_sensor.status Last 11:20:37 My MQTT configuration (local_mqtt_devices.yaml) for the related entity is: layzspa_message: type: ValueSensor capabilities: ["temperature_sensor", "value_sensor", "power_sensor"] primary_attribute: power_sensor.value events: "layzspa/message": "power_sensor.value": json_payload: true if_expr: '! isnull( payload?.PWR )' expr: "float(payload.PWR)" "value_sensor.air": json_payload: true if_expr: '! isnull( payload?.AIR )' expr: "float(payload.AIR)" "value_sensor.pump": json_payload: true if_expr: '! isnull( payload?.FLT )' expr: "float(payload.FLT)" "value_sensor.god": json_payload: true if_expr: '! isnull( payload?.GOD )' expr: "float(payload.GOD)" "value_sensor.lock": json_payload: true if_expr: '! isnull( payload?.LCK )' expr: "float(payload.LCK)" "value_sensor.unit": json_payload: true if_expr: '! isnull( payload?.UNT )' expr: "float(payload.UNT)" "value_sensor.error": json_payload: true if_expr: '! isnull( payload?.ERR )' expr: "float(payload.ERR)" "temperature_sensor.green": json_payload: true if_expr: '! isnull( payload?.GRN )' expr: "float(payload.GRN)" "temperature_sensor.red": json_payload: true if_expr: '! isnull( payload?.RED )' expr: "float(payload.RED)" "temperature_sensor.target": json_payload: true if_expr: '! isnull( payload?.TGT )' expr: "float(payload.TGT)" "temperature_sensor.value": json_payload: true if_expr: '! isnull( payload?.TMP )' expr: "float(payload.TMP)" "temperature_sensor.virtual": json_payload: true if_expr: '! isnull( payload?.VTM )' expr: "round(float(payload.VTM), 1)" "temperature_sensor.ambient": json_payload: true if_expr: '! isnull( payload?.AMB )' expr: "float(payload.AMB)" "layzspa/Status": "value_sensor.status": if_expr: '! isnull( payload )' expr: "payload" "layzspa/button": "value_sensor.button": if_expr: '! isnull( payload )' expr: "payload" and in reactor.yaml I have: "layzspa_states": name: "Lay-Z-Spa States" friendly_name: 'Lay-Z-Spa States' include: layzspa_message I realize my MQTT configuration might be a bit unorthodox, but could there still be something unintentional in the latest MQTTController build? If needed, I can provide detailed logs.
Multi-System Reactor
🎉 My very first MSR controller: OpenSprinkler
therealdbT
Since today is my birthday - and I still pretend to be unconventional - I'm giving away a present to this wonderful community and I'm releasing my first OpenSprinkler controller for MSR. It was real fun to code it - and while it's still WIP, it seems to work OK for me. It's polling-based at the moment, but I'll add support for updates via MQTT very soon (it's already partially coded). Get it at (install is similar to MQTTController and such): https://github.com/dbochicchio/reactor-opensprinkler Feel free to try it. It's beta software, but it's stable. I'll update it weekly until all the tasks from my todo list are empty. Since I've learnt a lot from this controller, I'll explore new controllers soon.
Multi-System Reactor
Advice reqeusted to migrate MSR from Bare Metal to Container
T
Good day all, I'm in the process of trying to shut down my 10 year old Linux home server that served many purposes, but primarily it's what I used for my NAS/Plex Media server. I migrated the NAS aspect of the server in November of last year to a true NAS solution (Ubiquti UNAS Pro), which is rack mount and much more efficient than my old tower, which it's only side benefit was heating my home office during the winter. Unfortunately it also means heating my home office during the summer, which were about to be in full swing. I have two things running on this 10 year old server at this point. MSR and pi-hole. I'm running Plex Media Server on Fedora Workstation in Podman on mini PC, which is much more energy efficient than my old tower. My next step is to migrate MSR. I know there are images of MSR out there, and creating it is well documented. I'm going to be using Podman instead of Docker for various reasons, but they work very similar. What I don't know, is what I need to do to migrate my existing Bare Metal installation over to a container. Has anyone done this? Any advice?
Multi-System Reactor
Reactor (Multi-System/Multi-Hub) Announcements
toggledbitsT
Build 21228 has been released. Docker images available from DockerHub as usual, and bare-metal packages here. Home Assistant up to version 2021.8.6 supported; the online version of the manual will now state the current supported versions; Fix an error in OWMWeatherController that could cause it to stop updating; Unify the approach to entity filtering on all hub interface classes (controllers); this works for device entities only; it may be extended to other entities later; Improve error detail in messages for EzloController during auth phase; Add isRuleSet() and isRuleEnabled() functions to expressions extensions; Implement set action for lock and passage capabilities (makes them more easily scriptable in some cases); Fix a place in the UI where 24-hour time was not being displayed.
Multi-System Reactor
Can´t restart or upgrade/deploy MSR
F
Topic thumbnail image
Multi-System Reactor
[Solved] Limit HA Entity in MSR
wmarcolinW
Topic thumbnail image
Multi-System Reactor
Organizing/ structuring rule sets and rules
R
Hi guys, Just wondering how you guys organize your rule sets and rules. I wish I had an extra layer to have some more granularity, but my feature request was not popular. Maybe there are better ways to organize my rule sets. I use the rule sets now primarily for rooms. So a rule set per room. But maybe grouping by functionality works better. Any examples/ suggestions would be appreciated.
Multi-System Reactor
Moving MSR from a QNAP container to RP 5 - some issues
Tom_DT
Topic thumbnail image
Multi-System Reactor
Widget deletion does not work and landing page (status) is empy
M
Topic thumbnail image
Multi-System Reactor
Need help reducing false positive notifications
T
Topic thumbnail image
Multi-System Reactor
Deleting widgets
tunnusT
Hopefully a trivial question, but how do you delete widgets in a status page? Using build 22266
Multi-System Reactor
MQTT configuration question
tunnusT
I have the following yaml configuration in local_mqtt_devices file x_mqtt_device: set_speed: arguments: speed: type: str topic: "command/%friendly_name%" payload: type: json expr: '{ "fan": parameters.speed }' While this works fine, I'm wondering how this could be changed to "fixed" parameters, as in this case "fan" only accepts "A", "Q" or a numeric value of 1-5?
Multi-System Reactor

PR #178 In-place modification of arrays in "each"

Scheduled Pinned Locked Moved Multi-System Reactor
4 Posts 2 Posters 278 Views 2 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • toggledbitsT Offline
    toggledbitsT Offline
    toggledbits
    wrote on last edited by toggledbits
    #1

    I'm moving the discussion on this out of the Mantis PR #178 for the benefit of all/documentation, and also because it's easier to type and format here.

    @LibraSun wrote in that PR:

    I'm 99% certain you'll explain this one away as "expected" but I naively believed it would yield different results:
    In an expression defined by:
    a=[1,2,3],
    each i in a:
    shift(a)
    // result (array) [1,2] (unexpected
    // expected [1,2,3]

    This has me thinking that 'each' is leaving items on the table, as I tried unsuccessfully pointing out above.

    The issue here is that your expression shift(a) is modifying the iteration subject array in place. Basically, here are the iteration steps that are run, starting with a=[1,2,3]

    1. First iteration: a=[1,2,3]; the local i is assigned the first array element 1, but it is not used in the expression. The expression shift(a) results in 1 and causes a to be reduced to [2,3] (the first element is shifted off and becomes the result). Since this is the last value in the expression, 1 is added to the each result array.
    2. Second iteration: a is now [2,3] because the previous iteration modified it. So i is assigned 3, because the iteration is on the second element/iteration through the array, but i is not used in the expression. The shift(a) causes a to be reduced to [3] and its return value is 2, so the value 2 is added to the iteration result array.
    3. Third iteration: a is now [3], and we are on the third iteration, but the iteration index of 3 (third iteration) is now off the end of the array (only 1 element long), so iteration stops.

    The result of this each is therefore [1,2] because those are two values that were shifted out, and a is left at [3] because there was no third run of shift() to remove it.

    As I said in the PR, modifying an array you are iterating through can be dangerous and confusing in many languages, because iterators keep state during iteration, and some operations you can do inside the iteration can and will invalidate that state in some way. In Lua on Vera, this often leads to deadlocks and crashes so bad that the box reboots, not just a Luup reload. It's a Bad Idea, and programmers who know are very wary of doing this type of thing in any language unless they are certain of the side-effects/lack of side-effects.

    Your additional example:

    a=[1,2,3], // The array 'a' is [1,2,3]
    a=unshift(a,0), // The array 'a' is [0,1,2,3]
    a=push(a,4), // The array 'a' is [0,1,2,3,4]
    each i in a: // Iterating over the 5 elements of 'a'
    shift(a) // Take the first element of 'a' and append it to result array [ ]
    // result [0,1,2] (unexpected)
    // and array 'a' is now [3,4]! (also unexpected)

    Also correct result. All of the gyrations before the each are not relevant to behavior here. At the start of the each, the array is [0,1,2,3,4] (5 elements). Iterations:

    1. a=[0,1,2,3,4], i=0, shift(a) returns 0 and modifies a to [1,2,3,4]; the each result array is now [0]
    2. a=[1,2,3,4], i=2, shift(a) returns 1 and modifies a to [2,3,4]; the each result array is now [0,1]
    3. a=[2,3,4], i=4, shift(a) returns 2 and modifies a to [3,4]; the each result array is now [0,1,2]
    4. Iteration stops because the iteration index/step is 4, but there remain only two elements in a=[3,4] (we're off the end of the array).

    So the each result is [0,1,2] and a is left with [3,4] and this is correct operation.

    Key points:

    • each keeps state during the iteration (as most iterators do) about the subject of the iteration; if the subject changes in a way that affects the state, unexpected results may occur;
    • The functions push(), pop(), shift() and unshift() modify the array in place. If you say b=shift(a) you get a value in b and a modified (shorter) a.

    Author of Multi-system Reactor and Reactor, DelayLight, Switchboard, and about a dozen other plugins that run on Vera and openLuup.

    1 Reply Last reply
    1
    • LibraSunL Offline
      LibraSunL Offline
      LibraSun
      wrote on last edited by LibraSun
      #2

      Thanks!
      I've read and re-read "Step 4" above numerous times, and it's not sinking in.
      No need to explain further, simply allow me to stew in these juices a while.
      I'll also rig this up a number of other ways (using multiple variables, for starters) to watch intended behavior in action.
      Still weirds me out. 🙂

      EDIT: I believe I understand now; the each loop is foiled mid-stream because the array a keeps shrinking with each iteration, whereas each thinks it's still holding onto a 5-element array. It's not, therefore it aborts.

      LESSON: It would make better sense to create an index array (=[0,1,2,...,N]) of the same length as a, and generate the result with:

      a=["a","b","c","d","e"], index=[0,1,2,3,4],
      each i in index: a[i]
      

      for which the trivial result would be a copy of a as I had been expecting in the original example.

      toggledbitsT 1 Reply Last reply
      0
      • LibraSunL LibraSun

        Thanks!
        I've read and re-read "Step 4" above numerous times, and it's not sinking in.
        No need to explain further, simply allow me to stew in these juices a while.
        I'll also rig this up a number of other ways (using multiple variables, for starters) to watch intended behavior in action.
        Still weirds me out. 🙂

        EDIT: I believe I understand now; the each loop is foiled mid-stream because the array a keeps shrinking with each iteration, whereas each thinks it's still holding onto a 5-element array. It's not, therefore it aborts.

        LESSON: It would make better sense to create an index array (=[0,1,2,...,N]) of the same length as a, and generate the result with:

        a=["a","b","c","d","e"], index=[0,1,2,3,4],
        each i in index: a[i]
        

        for which the trivial result would be a copy of a as I had been expecting in the original example.

        toggledbitsT Offline
        toggledbitsT Offline
        toggledbits
        wrote on last edited by toggledbits
        #3

        @librasun I'm not sure if this will help, but here's an example without arrays that demonstrates the common behavior of loop and iterator constructs often seen. Yes, there are variances across languages, but I think most programmers will agree that this is what they would expect from a new language, and then will be prepared (or surprised) by any differences from that norm:

        int n = 10;
        for ( int k = 0; k <= n; k = k + 1 ) {
            System.out.println( k );
            if ( k == 5 ) {
                n = 4;
            }
        }
        

        If you're not familiar with the for() loop construct (this is C/C++/Java-ish and a little different from Lua), the first expression is the initializer, the second is the continuation test, and the third is the post-effect. The initializer is run once before entering the loop, the continuation test is run before each iteration (and iteration stops if the test is false), and the post-effect is run at the end of each iteration. So in the absence of the if statement, this loop should output the numbers 0 through 10 inclusive.

        But what would you expect the output of this loop to be with the if statatement? I would expect:

        0
        1
        2
        3
        4
        5
        

        ...and the reason is that each trip through the loop, the test expression k < n is evaluated using the then-current values of k and n. So if n changes, as it does in this case when k reaches 5, the next eval of the loop's test expression would see the new value of n (4), and since we're now in a new iteration, k has gone to 6, which is not less than 4, so the loop exits there.

        What does not happen here is that the value of n is pre-determined at the start of the loop, and thus immune to a change within the loop. If that were the case, language consistency would demand that k also be pre-determined and not change in this expression, and this would be disastrous, because the loop could never operate properly (it would loop infinitely in most common applications of this form).

        @librasun said in PR #178 In-place modification of arrays in "each":

        LESSON: It would make better sense to create an index array (=[0,1,2,...,N]) of the same length as a, and generate the result with:

        Well, I'm not really sure what problem you're trying to solve, or if you're just doing crazy things to see what breaks (which is fine, that's a perfectly valid way to test something). Based on what you said you expected in your first example above, all you need is:

        a=[1,2,3];
        b=each i in a: i;
        

        This would produce your expected [1,2,3] in b. In other words, a copy of the array (a is unmodified here). It would thus follow:

        a=["a","b","c","d","e"],
        b=each i in a: i
        

        Would produce b=["a","b","c","d","e"] in a bit shorter way than your follow-on example.

        Author of Multi-system Reactor and Reactor, DelayLight, Switchboard, and about a dozen other plugins that run on Vera and openLuup.

        LibraSunL 1 Reply Last reply
        1
        • toggledbitsT toggledbits

          @librasun I'm not sure if this will help, but here's an example without arrays that demonstrates the common behavior of loop and iterator constructs often seen. Yes, there are variances across languages, but I think most programmers will agree that this is what they would expect from a new language, and then will be prepared (or surprised) by any differences from that norm:

          int n = 10;
          for ( int k = 0; k <= n; k = k + 1 ) {
              System.out.println( k );
              if ( k == 5 ) {
                  n = 4;
              }
          }
          

          If you're not familiar with the for() loop construct (this is C/C++/Java-ish and a little different from Lua), the first expression is the initializer, the second is the continuation test, and the third is the post-effect. The initializer is run once before entering the loop, the continuation test is run before each iteration (and iteration stops if the test is false), and the post-effect is run at the end of each iteration. So in the absence of the if statement, this loop should output the numbers 0 through 10 inclusive.

          But what would you expect the output of this loop to be with the if statatement? I would expect:

          0
          1
          2
          3
          4
          5
          

          ...and the reason is that each trip through the loop, the test expression k < n is evaluated using the then-current values of k and n. So if n changes, as it does in this case when k reaches 5, the next eval of the loop's test expression would see the new value of n (4), and since we're now in a new iteration, k has gone to 6, which is not less than 4, so the loop exits there.

          What does not happen here is that the value of n is pre-determined at the start of the loop, and thus immune to a change within the loop. If that were the case, language consistency would demand that k also be pre-determined and not change in this expression, and this would be disastrous, because the loop could never operate properly (it would loop infinitely in most common applications of this form).

          @librasun said in PR #178 In-place modification of arrays in "each":

          LESSON: It would make better sense to create an index array (=[0,1,2,...,N]) of the same length as a, and generate the result with:

          Well, I'm not really sure what problem you're trying to solve, or if you're just doing crazy things to see what breaks (which is fine, that's a perfectly valid way to test something). Based on what you said you expected in your first example above, all you need is:

          a=[1,2,3];
          b=each i in a: i;
          

          This would produce your expected [1,2,3] in b. In other words, a copy of the array (a is unmodified here). It would thus follow:

          a=["a","b","c","d","e"],
          b=each i in a: i
          

          Would produce b=["a","b","c","d","e"] in a bit shorter way than your follow-on example.

          LibraSunL Offline
          LibraSunL Offline
          LibraSun
          wrote on last edited by
          #4

          @toggledbits NOTE: Yes, it was just me trying to break stuff. I really don't have any outstanding needs at the moment in terms of my daily workflows. Thanks for the tutorial (which all makes sense)!

          1 Reply Last reply
          0
          • toggledbitsT toggledbits locked this topic on
          Reply
          • Reply as topic
          Log in to reply
          • Oldest to Newest
          • Newest to Oldest
          • Most Votes


          Recent Topics

          • Gradually turn on lights.
            G
            gwp1
            0
            4
            144

          • Stop the MSR by an external switch on Hubitat.
            wmarcolinW
            wmarcolin
            0
            1
            38

          • Error After Upgrade
            G
            gwp1
            0
            4
            106

          • Reset attribute value of entity in event handler
            R
            RHCPNG
            0
            5
            209

          • Need help figuring out how to delay a reset on reaction
            G
            gwp1
            0
            22
            931

          • Way to search for rules (rule state) in other rules
            T
            tamorgen
            0
            3
            104

          • Links to MSR from HA
            Tom_DT
            Tom_D
            0
            1
            93

          • Set Reaction > Script Action
            wmarcolinW
            wmarcolin
            0
            11
            439

          • Wiring Samotech SM308-S into light fitting
            akbooerA
            akbooer
            0
            2
            152

          • Errors after updating to MQTTController build 25139
            toggledbitsT
            toggledbits
            0
            6
            242

          • 🎉 My very first MSR controller: OpenSprinkler
            therealdbT
            therealdb
            5
            13
            920

          • Advice reqeusted to migrate MSR from Bare Metal to Container
            T
            tamorgen
            0
            5
            264
          Powered by NodeBB | Contributors
          Hosted freely by 10RUPTiV - Solutions Technologiques | Contact us
          • Login

          • Don't have an account? Register

          • Login or register to search.
          • First post
            Last post
          0
          • Categories
          • Recent
          • Tags
          • Popular
          • Unsolved