[Reactor] Bug when sending MQTT boolean payloads

[tamorgen]

Looking in the logs, looks like the login.html page is missing from the path.

[tmorgenthaler@galactica logs]$ cat reactor.log | grep login
[userauth-24117]2024-04-28T01:26:47.692Z <httpapi:ERR> [HTTPAPI]#1 request for /reactor/en-US/login.html failed: [Error] ENOENT: no such file or directory, open '/home/tmorgenthaler/reactor/reactorui/login.html' [-]
[userauth-24117]2024-04-28T01:26:50.733Z <httpapi:ERR> [HTTPAPI]#1 request for /reactor/en-US/login.html failed: [Error] ENOENT: no such file or directory, open '/home/tmorgenthaler/reactor/reactorui/login.html' [-]

[tmorgenthaler@galactica reactorui]$ pwd
/home/tmorgenthaler/reactor/reactorui
[tmorgenthaler@galactica reactorui]$ ls -al
total 32
drwxr-xr-x  4 tmorgenthaler tmorgenthaler  4096 Apr 26 11:28 .
drwxr-xr-x 16 tmorgenthaler tmorgenthaler  4096 Apr 26 11:29 ..
drwxr-xr-x  2 tmorgenthaler tmorgenthaler  4096 Apr 24 17:42 img
-rw-r--r--  1 tmorgenthaler tmorgenthaler 12290 Dec  8  2022 index.html
drwxr-xr-x  4 tmorgenthaler tmorgenthaler  4096 Apr 26 11:28 lib

[tamorgen]

I looked in the tar.gz file on my desktop, and I'm not seeing the login.html in the reactorui directory. That seems the to be the source of the issue.

[tamorgen]

@toggledbits,
So something is also going on with running reactions with the autoversion. They are hanging and not running. Immediately after restarting, the reactions run, however, within a few minutes, those reactions are hanging.

I even tried manually going into one of the rules (a simple rule for turning on a light) and ran the reaction, and it's not working.

I reverted back to the "lastest" release, and the automations are working again.

[toggledbits]

@tamorgen said in Need Testers:

I'm not seeing the login.html in the reactorui directory

Oy. OK. Fresh build is now up.

@tamorgen said in Need Testers:

those reactions are hanging.

I'm running this in my house, not seeing any issues. The engine is the same for 24115 and userauth; they are completely in sync except for the required elements to support user authentication, which has nothing to do with reaction. Still, anything is possible, but I wouldn't be able to discern much without the usual rules still applying: when things aren't going as expected, look at the logs... follow the posting guidelines...

[tamorgen]

@toggledbits,
Thanks for the updated version. I'll test it this evening after work.

I was only able to provide limited diagnostic information this morning before I headed to work. Reverting to 24115 latest version fixed the immediate issue of reactions not functioning, so everything would function normally while I was gone for the day.

If the reactions continue to hang with the revised version, I'll provide more detailed information and logs this evening.

[toggledbits]

@therealdb the fixed build I just put up (to include the missing HTML file) also includes a potential fix for VirtualEntityController to preserve attributes across upgrades. Let's see how it works out.

[gwp1]

@toggledbits I have not done that yet. One step at a time The Not found issue has been resolved with your latest build and Access Control is WAE. The Reactions issue I noted has also not reappeared.

I have noticed that the TOOLS>Restart Reactor button does not work and I see nothing in the logs whatsoever even after "elevator button-ing" it (press press press press press press press).

[toggledbits]

@gwp1 said in Need Testers:

I have noticed that the TOOLS>Restart Reactor button does not work

Make sure you've done a hard refresh on the browser to ensure that it has loaded all the latest files for the UI.

Failing that, hit F12 (usually) in your browser to open a Developer window, and then hit the Restart button and see if anything gets logged on the browser side.

[gwp1]

@toggledbits Completely slipped my mind to approach it from the browers. Derp.

Yep.

Logged in as the default admin with updated pwd.

[tamorgen]

@toggledbits said in Need Testers:

@tamorgen said in Need Testers:

I'm not seeing the login.html in the reactorui directory

Oy. OK. Fresh build is now up.

@tamorgen said in Need Testers:

those reactions are hanging.

I'm running this in my house, not seeing any issues. The engine is the same for 24115 and userauth; they are completely in sync except for the required elements to support user authentication, which has nothing to do with reaction. Still, anything is possible, but I wouldn't be able to discern much without the usual rules still applying: when things aren't going as expected, look at the logs... follow the posting guidelines...

Slow day at work. I was able to remote into my home server and installed the updated release. The login functions properly, and I'm not seeing the hanging reactions as I was this morning.

This is really great. Now I can securely access my reactor UI remotely if I have the need. The only thing that would make it better is 2FA, but this is a fantastic update.

[toggledbits]

@gwp1 said in Need Testers:

Logged in as the default admin

When you reload the page, do you get any similar errors, specifically for /api/v1/systime? Is the time display in the page header correct (showing both host and browser times)?

[gwp1]

@toggledbits no errors for /api/v1/systime and the browser time and system time are identical, perhaps a split second apart as they tick by.

[therealdb]

@toggledbits yep, it's working beautifully time to delete some junky code I wrote for the occasion

I'll play with AuthN&AuthZ on May 1st, since it's a public holiday here in Italy and rain is forecast.

[toggledbits]

@therealdb said in Need Testers:

yep, it's working beautifully

Outstanding. I can apply the same type of fix to MQTTController, so I'll do that.

[gwp1]

@toggledbits I have finally finished up the SSL and am getting this from my local browser:

Going to spin this off into it's own thread.

[toggledbits]

Build 24120

• Mostly code cleanup and tightening around application restriction.
• Should fix Tools > Restart Reactor issue

[toggledbits]

Not hearing a lot of grumbling, which is a Good Thing so far. Any and all feedback welcome. Please comment on the docs, too, if you have anything. On my end, I'm out of things to do on this feature, nothing to add, so I'm just waiting for fixing/tweaking.

[tunnus]

@toggledbits thanks for this feature! I sort of had to volunteer as a tester as I originally did a feature request for authentication support...

Anyway, seems to work nicely, although only about an hour of testing behind. Will keep you posted if anything unexpected comes up. You could update docs though:

"1. Copy the template users.yaml-dist from the dist-config distribution directory to your config directory."

--> "1. Copy the template users.yaml-dist from the /opt/reactor/dist-config distribution directory to your config directory. Rename it as users.yaml file."

(at least for me as a Docker user it wasn't immediately clear where to find this template)

[Pabla]

@tunnus Yes this would be a good improvement to the docs.. you weren't the only one who made this mistake lol!

[tunnus]

well, I actually knew to rename this file, but it took a while to find that template (as I've used MSR container for years now and did not remember the location of dist-config)