[Reactor] Variables not updating correctly in latest-25201-2aa18550

[SweetGenius]

I updated MSR to 21239 and now no rules will run. The log files shows
Rule:CRIT Error: Cannot find module 'common/util'
I updated per the docs like always. I have also tried rebuilding the docker image from scratch with the same result. (not changing the data folders) This is Synology Docker Image, latest-generic-amd64. Build number from MSR says latest-21239-b87b5b9
@toggledbits , What did a break?

Log File:
2021-08-28T16:19:12.102Z Rule:5:777:Rule.js Rule#rule-kpw0p0rl dependency notification entity-changed Entity#hubitat>12 from Entity#hubitat>12
2021-08-28T16:19:12.103Z Rule:5:783:Rule.js Rule#rule-kpw0p0rl requesting eval; entity-changed Entity#hubitat>12
2021-08-28T16:19:12.103Z Rule:5:993:Rule.js Rule#rule-kpw0p0rl (Pantry Light) evaluate() acquiring mutex
2021-08-28T16:19:12.104Z Rule:5:997:Rule.js Rule#rule-kpw0p0rl._evaluate() mutex acquired, evaluating
2021-08-28T16:19:12.104Z Rule:5:1001:Rule.js Rule#rule-kpw0p0rl update rate is 1/min limit 60/min
2021-08-28T16:19:12.104Z Rule:5:921:Rule.js Rule#rule-kpw0p0rl evaluateExpressions() with 0 expressions
2021-08-28T16:19:12.105Z Rule:CRIT Error: Cannot find module 'common/util'
Require stack:

• /opt/reactor/server/lib/Engine.js
• /opt/reactor/server/lib/httpapi.js
• /opt/reactor/app.js
  Error: Cannot find module 'common/util'
  Require stack:
• /opt/reactor/server/lib/Engine.js
• /opt/reactor/server/lib/httpapi.js
• /opt/reactor/app.js
  at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
  at Function.Module._load (internal/modules/cjs/loader.js:746:27)
  at Module.require (internal/modules/cjs/loader.js:974:19)
  at require (internal/modules/cjs/helpers.js:92:18)
  at Engine._get_lexp_extensions (/opt/reactor/server/lib/Engine.js:857:25)
  at Rule.evaluateExpressions (/opt/reactor/server/lib/Rule.js:921:286)
  at Rule._evaluate (/opt/reactor/server/lib/Rule.js:1011:323)
  at processTicksAndRejections (internal/process/task_queues.js:95:5)
  at async /opt/reactor/server/lib/Rule.js:980:17

[Crille]

@sweetgenius and @toggledbits I also had a lot of errors in my log after update on my bare metal Ubunu. I had to revert to 1.0.0-21200 to have a clean log again.

[toggledbits]

How are you starting Reactor on Ubuntu?

[Crille]

@toggledbits With systemd.

[toggledbits]

Add the following line to the Service section of the service file in /etc/systemd/system:

Environment=NODE_PATH=/home/myuser/reacto

Then:

sudo systemctl daemon-reload
sudo systemctl restart reactor

[Crille]

@toggledbits I suspected you would suggest that so I've just tried that and updated but same errors so I reverted again.

[toggledbits]

OK. You need to have that line in there, pointing to the correct (reactor) directory.

I've just respun the builds as well, missing a new file. Please pull the docker image and redownload the bare metal package/reinstall.

And while you're at it, do a npm update --no-save on the Ubuntu side.

[Crille]

Yes, definitely keeping the environment config and will do npm update. There's no new timestamps on the builds in latest directory though?

[Crille]

@toggledbits Still no luck. npm updated to latest and all other suggestions applied. Should there be a new filename or timestamp on the tar.qz download?

Reactor starts but when I run a reaction this shows in alerts:

Reaction task "1" failed due to an exception. Please see the log.
Error: Cannot find module 'common/util'
Require stack:
- /home/user/reactor/server/lib/Engine.js
- /home/user/reactor/server/lib/httpapi.js
- /home/user/reactor/app.js

and the log is full of related erros.

[SweetGenius]

I pulled a new Docker image and it appears to have fixed the issue. Thank You.