Logic Programming

[akbooer]

Helpful, thanks. That’s something for me to get my teeth into…

[akbooer]

Any other errors in the startup log, or since startup in the main log?

[akbooer]

@DesT

I did an install of the latest openLuup from the development branch (v23.3.21) and semm to have no problem accessing the console page. Will try again, now, to install the lxp module and fire up the RulesEngine...

[akbooer]

On the RulesEngine saving issue...

I've been seeing this error in the browser console:

POST
http://172.16.42.10:49162/cgi-bin/cmh/upload_upnp_file.sh
404 Not Found

...and I found that the file was missing from my installation (which I had done manually, because the AltAppStore configuration doesn't handle the GitHub structure of the repository.)

Do you have the folders and file (within the openLuup home folder) ?

[DesT]

yes I have the file and it contain:

#!/usr/bin/env wsapi.cgi

module(..., package.seeall)

-- @vosmont's implementation of /cgi-bin/cmh/upload_upnp_file.sh
-- converted to WSAPI application by @akbooer
-- see: http://keplerproject.github.io/wsapi/manual.html
--
-- 2016.02.18  extract vosmont's modification from openLuup.server and make into WSAPI app
--

local _log    -- defined from WSAPI environment as error.write(...) in run() method.

-- create the file
local function upload_file (URL)
  local file, status, result
  local path = "" -- should use a specific folder for security reason ?
  local fileName, fileContent = URL.upnp_file_1_name, URL.upnp_file_1
  if fileName and fileContent then
    file = io.open(path .. fileName, "w")
  end
  fileName = fileName or '?'
  if (file == nil) then
    _log ("File '" .. path .. fileName .. "' cannot be created")
     result = "KO"
     status = 400   -- Bad Request.
  else
    file:write(fileContent)
    file:close()
    _log ("File '" .. path .. fileName .. "' has been written")
    result = "OK"
    status = 201    -- Created. The request has been fulfilled and resulted in a new resource being created
  end
  return status, result .. "|" .. fileName, "text/html"
end

-- gets headers in multipart content
local function read_part_headers (content, pos)
        local EOH = "\r\n\r\n"
        local i, j = string.find(content, EOH, pos, true)
        if i then
                local header_data = string.sub(content, pos, j - 1)
                local headers = {}
                for type, val in string.gmatch(header_data, '([^%c%s:]+):%s+([^\n]+)') do
                        headers[type] = val
                end
                return headers, j + 1
        else
                return nil, pos
        end
end

-- gets fields in multipart headers
local function get_field_names(headers)
        local disp_header = headers["Content-Disposition"] or ""
        local attrs = {}
        for attr, val in string.gmatch(disp_header, ';%s*([^%s=]+)="(.-)"') do
                attrs[attr] = val
        end
        return attrs.name, attrs.filename and string.match(attrs.filename, "[/\\]?([^/\\]+)$")
end

-- gets the data in multipart content
local function read_field_content(content, boundary, pos)
        local i, j = string.find(content, "\r\n" .. boundary, pos, true)
        if i then
                return string.sub(content, pos, i - 1), j + 1
        else
                return nil, pos
        end
end


-- global entry point called by WSAPI connector

--[[

The environment is a Lua table containing the CGI metavariables (at minimum the RFC3875 ones) plus any
server-specific metainformation. It also contains an input field, a stream for the request's data,
and an error field, a stream for the server's error log.

The input field answers to the read([n]) method [AKB: NOT YET IMPELMENTED],
where n is the number of bytes you want to read
(or nil if you want the whole input[AKB: THIS IS IMPLEMENTED]).

The error field answers to the write(...) method.

return values: the HTTP status code, a table with headers, and the output iterator.

--]]

function run (wsapi_env)
  _log = wsapi_env.error.write     -- set up the log output

        -- vosmont : add upload file management
  -- inspired from https://github.com/keplerproject/wsapi
  local URL = {}

  -- get POST content,
  local post_content = wsapi_env.input.read()

  local content_type = wsapi_env["CONTENT_TYPE"]

  -- get uploaded file
  if string.find(content_type, "multipart/form-data", 1, true) then
    local boundary = "--" .. string.match(content_type, "boundary%=(.-)$")
    -- get all the parts
    local pos = 1
    local _, part_headers, name, value
    _, pos = string.find(post_content, boundary, 1, true)
    pos = pos + 1
    part_headers, pos = read_part_headers(post_content, pos)
    while (part_headers) do
      --_log ("HTTP POST request multipart headers : " .. json.encode(part_headers))
      name, _ = get_field_names(part_headers) -- do not use "file_name" in Vera implementation of uploading files
      value, pos = read_field_content(post_content, boundary, pos)
      URL[name] = value
      -- prepare next multipart scan
      part_headers, pos = read_part_headers(post_content, pos)
    end
  end
  --_log ("HTTP POST request content : " .. post_content)
  --_log ("HTTP POST request content : " .. json.encode(URL))

  local status, return_content, return_content_type = upload_file (URL)

  local headers = {["Content-Type"] = return_content_type}

  local function iterator ()     -- one-shot iterator, returns content, then nil
    local x = return_content
    return_content = nil
    return x
  end

  return status, headers, iterator
end

-----

[DesT]

@akbooer had some time to find something?

[akbooer]

Been away for a couple of weeks. That missing file was the last thing I tried. Will get back to it now!

[akbooer]

So I've got this far. What so I do now...?

[DesT]

You can try to create a basic rule like that:

than try to save it!

[DesT]

You should see the rule in the list after but you will not be able to edit it or see it!

Clicking on the pen will bring the EDIT window BUT you should see nothing as the rule is not saved properly.

Clicking on the big icon on the left, should bring the "view" and should see nothing also as the rule is not saved properly

[akbooer]

I see these errors in the bowser console when constructing the rule:

When saving, I get from the openLuup log:

2023-09-20 15:00:49.723   openLuup.server:: POST /cgi-bin/cmh/upload_upnp_file.sh HTTP/1.1 tcp{client}: 0x55edaf542828
2023-09-20 15:00:49.758   openLuup.wsapi.cgi:: /cgi-bin/cmh/upload_upnp_file.sh : File 'C_RulesEngine_Rules.xml' has been written
2023-09-20 15:00:49.758   openLuup.server:: request completed (124 bytes, 0 chunks, 34 ms) tcp{client}: 0x55edaf542828
2023-09-20 15:00:49.767   openLuup.server:: GET /data_request?id=action&output_format=json&DeviceNum=5&serviceId=urn:upnp-org:serviceId:RulesEngine1&action=LoadRules&fileName=C_RulesEngine_Rules.xml&ruleIdx=1 HTTP/1.1 tcp{client}: 0x55edaf542828
2023-09-20 15:00:49.768   luup.call_action:: 5.urn:upnp-org:serviceId:RulesEngine1.LoadRules 
2023-09-20 15:00:49.768   openLuup.server:: request completed (62 bytes, 1 chunks, 0 ms) tcp{client}: 0x55edaf542828

2023-09-20 15:00:49.768   openLuup.context_switch::  ERROR: [dev #5] [string "I_RulesEngine1.xml"]:25: attempt to index field 'RulesFile' (a nil value)

2023-09-20 15:00:49.768   openLuup.scheduler:: job aborted : [string "I_RulesEngine1.xml"]:25: attempt to index field 'RulesFile' (a nil value)
2023-09-20 15:00:49.771   openLuup.server:: GET /data_request?id=lr_RulesEngine&command=getRulesInfos&output_format=json HTTP/1.1 tcp{client}: 0x55edaf542828
2023-09-20 15:00:49.771   openLuup.server:: request completed (31 bytes, 1 chunks, 0 ms) tcp{client}: 0x55edaf542828

So it's not clear what's going wrong here. There are some 5,400 lines of Lua, and 1,950 of Javascript to look through...

[akbooer]

I see also that it does create the file C_RulesEngine_Rules.xml with valid XML.

[DesT]

If that can help.... the "TEST" rule I created 2 days ago for you, I'm able to delete it BUT any other rules I can't... maybe it's related to changing/removing a rule that it's not the last one...

I can do some more testing if you want!