As the title says, here's my OpenAI Controller for Reactor:
OpenAI Controller per Reactor. Contribute to dbochicchio/reactor-openai development by creating an account on GitHub.
It supports both OpenAI and Azure OpenAI endpoints. You'll need keys/endpoints, according to each service.
The controller supports multiple models, and each one could be mapped as an entity.
It's quite easy to use, and responses can be stored in variables, for easy access. Or sent to another action (Text To Speech, another endpoint, etc).
9013ae50-fd68-42a2-87c3-97479132e465-image.png
80a88eec-7c89-464a-8196-690b4b72d044-image.png
Have fun with LLM into your scenes!
In Home Assistant I have an integration that if I add entities to it, I will get the following error in MSR as certain entity values I'm using in expressions are null for a moment. This is more or less cosmetic issue and happens very rarely as I rarely modify that integration on the hass side.
Screenshot 2024-11-28 at 22.20.41.png
And the expression is
Screenshot 2024-11-28 at 22.38.19.png
Could I "wrap" hass-entity shown above somewhat differently to prevent this error from happening? Using build 24302.
Hello
I am trying to set up Multi System Reactor to automate routines across multiple smart home devices & platforms (e.g., Home Assistant, SmartThings, and Hubitat). While I have successfully linked the systems; I am facing issues with:
-Delays in triggering actions on secondary devices.
-Inconsistent execution of complex logic conditions.
-Synchronization of states between devices when one system updates.
Is there a recommended way to optimize performance & confirm seamless state sharing across systems?
I have checked https://smarthome.community/category/22/multi-system-reactor-msbi guide for reference but still need advice.
Any tips on debugging or log analysis to pinpoint where the issue arises would also be appreciated.
Thank you !
I've managed to use MSR UI on iOS devices to some degree*, so that although UI elements (e.g. rule sets) are not visible in portrait mode, you've seen them in landscape. Now with recents builds (24302) this does not work anymore, elements (rule sets, entities) are not anymore visible in landscape mode.
Does anyone have similar experiences? Using iOS 18 and Safari/Chrome browser.
( *Drag & drop of rule conditions have never worked on a mobile)
@toggledbits Since I have upgraded ZWaveJSController to 24293 from 24257 I am seeing entries related to registering action set_volume, but action is not defined by the capability 143 every time I restart Reactor.
The Siren seems to be doing what it is supposed to do. The volume levels are fine. Should I worry about it?
Reactor version 24302
ZWaveJSController version 24293
Z-Wave JS UI version 9.27.4
zwave-js version 14.3.4
I have the following ACL defined:
groups: admin: users: - admin applications: true api_acls: # This ACL allows users in the "admin" group to access the API - url: "/api" group: admin allow: true log: true # This ACL allows anyone/thing to access the /api/v1/alive API endpoint - url: "/api/v1/alive" allow: trueAnd I have authenticated to MSR as "admin" user. However, I'm getting "access denied" when trying to access http://*******:8111/api/v1/log
So what I'm missing, is my ACL incorrectly defined?
Using build 24302 on Docker.
Thanks to @toggledbits for adding a custom CSS. I've started doing a darker Reactor style.
Here's the file: https://gist.github.com/dbochicchio/825098ac13b7f8cac22012eae37ff7ce
A couple of things are still too bright and I'll eventually catch-up. Just place it under your /config directory, naming the file as customstyles.css. Hard refresh your browser.
Hi
I have just connected a bunch of EzloPi controllers to MSR to import some ESP based devices etc.
They all seemed to have worked and imported in to MSR apart from I have one missing device. It is a Digital Gas Sensor device.
This is how that device looks in the Ezlo API.
Devices Info:
_id: "10696001" deviceTypeId: "ezlopi" parentDeviceId: "10696000" category: "level_sensor" subcategory: "" gatewayId: "457a5069" batteryPowered: false name: "Gas Sensor Digital" type: "sensor" reachable: true persistent: true serviceNotification: false armed: false roomId: "" security: "no" ready: true status: "idle" parentRoom: true protectConfig: "default"Items Info:
_id: "20696001" deviceId: "10696001" hasGetter: true hasSetter: false name: "smoke_density" show: true valueType: "substance_amount" scale: "parts_per_million" value: 2.7472610473632812 valueFormatted: "2.75" status: "idle"There is also an Analog Gas sensor that one did import in to MSR OK.
68d63dab-b871-4f44-912b-cf6e0b9eb4c6-image.png
Devices Info:
_id: "10696000" deviceTypeId: "ezlopi" parentDeviceId: "10696000" category: "security_sensor" subcategory: "gas" gatewayId: "457a5069" batteryPowered: false name: "Gas Sensor Analog" type: "sensor" reachable: true persistent: true serviceNotification: false armed: false roomId: "" security: "no" ready: true status: "idle" parentRoom: true protectConfig: "default"Items Info:
_id: "20696000" deviceId: "10696000" hasGetter: true hasSetter: false name: "gas_alarm" show: true valueType: "token" enum: 0: "no_gas" 1: "combustible_gas_detected" 2: "toxic_gas_detected" 3: "unknown" valueFormatted: "no_gas" value: "no_gas" status: "idle"And this is how this MQ2 Gas Sensor looks like on their dashboard:
Digital
cb77dfa3-4af5-4d06-9635-89207a716a89-image.png
Analog
4fb4da1b-e946-4b89-876c-bcd9f5699b6c-image.png
They have an EzloPi website here you can create your own sensor projects using ESP boards, which is very interesting stuff!
And I just wrote on the Ezlo forum here, how to connect an EzloPi controller to MSR.
THANKS.
Build 21228 has been released. Docker images available from DockerHub as usual, and bare-metal packages here.
Home Assistant up to version 2021.8.6 supported; the online version of the manual will now state the current supported versions; Fix an error in OWMWeatherController that could cause it to stop updating; Unify the approach to entity filtering on all hub interface classes (controllers); this works for device entities only; it may be extended to other entities later; Improve error detail in messages for EzloController during auth phase; Add isRuleSet() and isRuleEnabled() functions to expressions extensions; Implement set action for lock and passage capabilities (makes them more easily scriptable in some cases); Fix a place in the UI where 24-hour time was not being displayed.A couple of things for you @toggledbits, since you mentioned that this release has new features and some tweaks are expected.
Local expressions cannot be deleted. Pushing the X button has no effect for me.
When cloning an entity action, the result is strange (first is cloned one, second is the original action):
a92ea094-9e2c-4aaa-bf47-2d07a6ffdbd0-image.png
When changing the action on the cloned element, the params are added to the original one. See screenshot:
92ac3011-83c8-466b-bd23-47d483ad7a52-image.png
Dark theme has a couple of strange contrasts. One is visible in the previous screenshots (white text on yellow background). Another one is in groups (blue text on blue background):
9b3c4988-53ef-44e6-9672-30e744cacb75-image.png
Overall, I found blue, yellow, red and green (in buttons and forms) to be too bright.
On the bright side:
I love the new script action: thank you! The dark theme is a great start to avoid getting blinded at night I promise I'll try very soon the new features around actions. Thanks!@toggledbits
I just upgraded to version MSR 24293, bare metal running on Fedora. Upon restart, I am getting a error banner:
I followed the new directions about npm
npm i --no-save --no-package-lock --omit dev
Any idea what the issue is?
Seems like switching the UI to the newly added dark mode (thank you for this) does nothing. The UI stays in light mode and only a few buttons turn into dark mode (see screenshot)
Things I have tried:
Hard refresh
Different browser
Different computer
Restarting Reactor
Failed troubleshooting attempts:
No errors in Chrome console
No relevant errors in Reactor log (can still PM the full log file)
Reactor version: latest-24293-ea42a81d
Hardware: Odroid N2+
Linux version: Ubuntu 24.04.1 LTS
3df2806f-9146-485b-9ec1-d056e91cefe5-image.png Dark mode enabled
ff823023-c079-4684-b01f-d6ac6527d31a-image.png Light mode enabled
Good morning,
I have a service MQTT service that needs a restart occasionally. The add-on (Smartbed MQTT) is for the smart bed base for my bed. It has a "safety light" that I can control from HAAS & MSR as a light entity, and also moves the head of the bed to a preset at bedtime, and then lies it back flat in the morning The problem is, from time to time, the light becomes "unavailable" Restarting from the Add-ons tab in HAAS always fixes it, but I should be able to detect when it happens when "light.tempur_pedic_safety_lights" is not true or false, i.e., unavailable.
What I don't know how to do is how to restart that service. Does anybody have experience in restarting add-ons from MSR?
Running:
Reactor (Multi-hub) latest-24212-3ce15e25 ZWaveJSController [0.1.24232]HAAS:
RPi5-64 (8GB) Core 2024.7.3 Supervisor 2024.08.0 Operating System 13.0 Frontend 20240710.0
Hi!
Is it possible to generate two additional log files, the first being the replica of what is displayed on screen by the Rule History widgets and the other with Recently Changed Entities?
And could I configure the generation of one file per day, and delete the older ones? For example, store the last 5 days?
And being more ambitious, does Windget have an icon to open these TXT files in the navigated?
Well, we're approaching Christmas, so here's my request to Santa Claus @toggledbits 🙂
Hi @toggledbits
I'm working on a controller to generate llm response from a prompt in reactor. I have http response coming thru an http request action at the moment, capturing the response inside a local variable. So, it's practically sync.
I want to create a controller, so I don't have to rely on a proxy (and have a simpler architecture), and duplicate absurd http actions, but AFAIK in the current implementation, actions are async only. But if I have multiple requests going on, I cannot be sure what it's really inside an attribute. I also thought that something like a correlation id when sending the request could be used to identity multiple responses, but I wanted to double check with you before starting with something too complicated. I also noticed that some actions in home assistant (ie forecast) are sync and I'm wondering if you have any plan or hint to address this situation. Thanks.
Thanks.
@togglebits I am curious as to why the tilt_sensor.state (primary) = NULL. I believe it should show true or false. I have to use binary_sensor.state instead in my rules.
Again, not sure if this is related to Reactor/ZwaveJSController implementation or the actual Z-Wave JS UI docker version. I have copied, below, the attributes of the tilt sensor in hopes it can help.
Thanks in advance.
Reactor version 23302
ZWaveJSController version 23254
Z-Wave JS UI version 9.3.0.724519f
zwave-js version 12.2.3
MQTT interface... time for some testing. Where are my experts?
-
This is what I see when running step5 ./install.sh
Installing dependencies... make: Entering directory '/home/kevin/reactor/ext/MQTTController/node_modules/in otify/build' CXX(target) Release/obj.target/inotify/src/bindings.o In file included from ../src/bindings.cc:2:0: ../src/bindings.h:10:27: error: ‘Handle’ has not been declared static void Initialize(Handle<Object> target); ^~~~~~ ../src/bindings.h:10:33: error: expected ‘,’ or ‘...’ before ‘<’ token static void Initialize(Handle<Object> target); ^ ../src/bindings.cc:11:27: error: variable or field ‘Initialize’ declared void void Inotify::Initialize(Handle<Object> exports) { ^~~~~~ ../src/bindings.cc:11:27: error: ‘Handle’ was not declared in this scope ../src/bindings.cc:11:27: note: suggested alternative: ‘rand_r’ void Inotify::Initialize(Handle<Object> exports) { ^~~~~~ rand_r ../src/bindings.cc:11:40: error: expected primary-expression before ‘>’ token void Inotify::Initialize(Handle<Object> exports) { ^ ../src/bindings.cc:11:42: error: ‘exports’ was not declared in this scope void Inotify::Initialize(Handle<Object> exports) { ^~~~~~~ ../src/bindings.cc: In static member function ‘static Nan::NAN_METHOD_RETURN_TYP E NodeInotify::Inotify::AddWatch(Nan::NAN_METHOD_ARGS_TYPE)’: ../src/bindings.cc:146:43: error: no matching function for call to ‘v8::Value::T oObject()’ Local<Object> args_ = info[0]->ToObject(); ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:67 :0, from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:2672:44: note: candidate: v8::MaybeLocal<v8::Object> v8::Value::ToObject(v8::Local<v8::Context>) const V8_WARN_UNUSED_RESULT MaybeLocal<Object> ToObject( ^~~~~~~~ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:2672:44: note: candidate expects 1 argument, 0 provided In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8-intern al.h:14:0, from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:27, from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:6 , from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:2686:31: note: candidate: v8::Local<v8::Object> v8::Value::ToObject(v8::Isolate*) const Local<Object> ToObject(Isolate* isolate) const); ^ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8config.h:328:3: note: in defi nition of macro ‘V8_DEPRECATED’ declarator __attribute__((deprecated(message))) ^~~~~~~~~~ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:2686:31: note: candidate expects 1 argument, 0 provided Local<Object> ToObject(Isolate* isolate) const); ^ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8config.h:328:3: note: in defi nition of macro ‘V8_DEPRECATED’ declarator __attribute__((deprecated(message))) ^~~~~~~~~~ ../src/bindings.cc:149:27: error: no matching function for call to ‘v8::Object:: Has(v8::Local<v8::String>&)’ if (!args_->Has(path_sym)) { ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:67 :0, from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3590:37: note: candidate: v8::Maybe<bool> v8::Object::Has(v8::Local<v8::Context>, v8::Local<v8::Value>) V8_WARN_UNUSED_RESULT Maybe<bool> Has(Local<Context> context, ^~~ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3590:37: note: candidate expects 2 arguments, 1 provided /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3596:37: note: candidate: v8::Maybe<bool> v8::Object::Has(v8::Local<v8::Context>, uint32_t) V8_WARN_UNUSED_RESULT Maybe<bool> Has(Local<Context> context, uint32_t index) ; ^~~ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3596:37: note: candidate expects 2 arguments, 1 provided ../src/bindings.cc:154:31: error: no matching function for call to ‘v8::Object:: Has(v8::Local<v8::String>&)’ if (!args_->Has(callback_sym) || ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:67 :0, from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3590:37: note: candidate: v8::Maybe<bool> v8::Object::Has(v8::Local<v8::Context>, v8::Local<v8::Value>) V8_WARN_UNUSED_RESULT Maybe<bool> Has(Local<Context> context, ^~~ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3590:37: note: candidate expects 2 arguments, 1 provided /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3596:37: note: candidate: v8::Maybe<bool> v8::Object::Has(v8::Local<v8::Context>, uint32_t) V8_WARN_UNUSED_RESULT Maybe<bool> Has(Local<Context> context, uint32_t index) ; ^~~ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3596:37: note: candidate expects 2 arguments, 1 provided ../src/bindings.cc:155:28: warning: ‘v8::Local<v8::Value> v8::Object::Get(v8::Lo cal<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declarations] !args_->Get(callback_sym)->IsFunction()) { ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8-intern al.h:14:0, from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:27, from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:6 , from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3553:51: note: declared he re V8_DEPRECATED("Use maybe version", Local<Value> Get(Local<Value> key)); ^ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8config.h:328:3: note: in defi nition of macro ‘V8_DEPRECATED’ declarator __attribute__((deprecated(message))) ^~~~~~~~~~ ../src/bindings.cc:160:32: error: no matching function for call to ‘v8::Object:: Has(v8::Local<v8::String>&)’ if (!args_->Has(watch_for_sym)) { ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:67 :0, from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3590:37: note: candidate: v8::Maybe<bool> v8::Object::Has(v8::Local<v8::Context>, v8::Local<v8::Value>) V8_WARN_UNUSED_RESULT Maybe<bool> Has(Local<Context> context, ^~~ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3590:37: note: candidate expects 2 arguments, 1 provided /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3596:37: note: candidate: v8::Maybe<bool> v8::Object::Has(v8::Local<v8::Context>, uint32_t) V8_WARN_UNUSED_RESULT Maybe<bool> Has(Local<Context> context, uint32_t index) ; ^~~ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3596:37: note: candidate expects 2 arguments, 1 provided ../src/bindings.cc:163:33: warning: ‘v8::Local<v8::Value> v8::Object::Get(v8::Lo cal<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declarations] if (!args_->Get(watch_for_sym)->IsInt32()) { ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8-intern al.h:14:0, from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:27, from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:6 , from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3553:51: note: declared he re V8_DEPRECATED("Use maybe version", Local<Value> Get(Local<Value> key)); ^ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8config.h:328:3: note: in defi nition of macro ‘V8_DEPRECATED’ declarator __attribute__((deprecated(message))) ^~~~~~~~~~ ../src/bindings.cc:166:36: warning: ‘v8::Local<v8::Value> v8::Object::Get(v8::Lo cal<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declarations] mask |= args_->Get(watch_for_sym)->Int32Value(); ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8-intern al.h:14:0, from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:27, from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:6 , from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3553:51: note: declared he re V8_DEPRECATED("Use maybe version", Local<Value> Get(Local<Value> key)); ^ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8config.h:328:3: note: in defi nition of macro ‘V8_DEPRECATED’ declarator __attribute__((deprecated(message))) ^~~~~~~~~~ ../src/bindings.cc:166:50: error: no matching function for call to ‘v8::Value::I nt32Value()’ mask |= args_->Get(watch_for_sym)->Int32Value(); ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:67 :0, from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:2709:40: note: candidate: v8::Maybe<int> v8::Value::Int32Value(v8::Local<v8::Context>) const V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const ; ^~~~~~~~~~ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:2709:40: note: candidate expects 1 argument, 0 provided ../src/bindings.cc:172:45: warning: ‘v8::Local<v8::Value> v8::Object::Get(v8::Lo cal<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declarations] String::Utf8Value path(args_->Get(path_sym)); ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8-intern al.h:14:0, from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:27, from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:6 , from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3553:51: note: declared he re V8_DEPRECATED("Use maybe version", Local<Value> Get(Local<Value> key)); ^ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8config.h:328:3: note: in defi nition of macro ‘V8_DEPRECATED’ declarator __attribute__((deprecated(message))) ^~~~~~~~~~ ../src/bindings.cc:172:46: error: no matching function for call to ‘v8::String:: Utf8Value::Utf8Value(v8::Local<v8::Value>)’ String::Utf8Value path(args_->Get(path_sym)); ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:67 :0, from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3135:5: note: candidate: v 8::String::Utf8Value::Utf8Value(v8::Isolate*, v8::Local<v8::Value>) Utf8Value(Isolate* isolate, Local<v8::Value> obj); ^~~~~~~~~ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3135:5: note: candidate expects 2 arguments, 1 provided ../src/bindings.cc:182:61: warning: ‘v8::Local<v8::Value> v8::Object::Get(v8::Lo cal<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declarations] inotify->handle()->Set(descriptor, args_->Get(callback_sym)); ^ -
IN two posts because was too long - sorry
In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8-intern al.h:14:0, from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:27, from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:6 , from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3553:51: note: declared he re V8_DEPRECATED("Use maybe version", Local<Value> Get(Local<Value> key)); ^ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8config.h:328:3: note: in defi nition of macro ‘V8_DEPRECATED’ declarator __attribute__((deprecated(message))) ^~~~~~~~~~ ../src/bindings.cc:182:62: warning: ‘bool v8::Object::Set(v8::Local<v8::Value>, v8::Local<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declaratio ns] inotify->handle()->Set(descriptor, args_->Get(callback_sym)); ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8-intern al.h:14:0, from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:27, from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:6 , from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3499:22: note: declared he re bool Set(Local<Value> key, Local<Value> value)); ^ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8config.h:328:3: note: in defi nition of macro ‘V8_DEPRECATED’ declarator __attribute__((deprecated(message))) ^~~~~~~~~~ ../src/bindings.cc: In static member function ‘static Nan::NAN_METHOD_RETURN_TYP E NodeInotify::Inotify::RemoveWatch(Nan::NAN_METHOD_ARGS_TYPE)’: ../src/bindings.cc:195:31: error: no matching function for call to ‘v8::Value::I nt32Value()’ watch = info[0]->Int32Value(); ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:67 :0, from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:2709:40: note: candidate: v8::Maybe<int> v8::Value::Int32Value(v8::Local<v8::Context>) const V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const ; ^~~~~~~~~~ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:2709:40: note: candidate expects 1 argument, 0 provided ../src/bindings.cc: In static member function ‘static void NodeInotify::Inotify: :Callback(uv_poll_t*, int, int)’: ../src/bindings.cc:262:86: warning: ‘bool v8::Object::Set(v8::Local<v8::Value>, v8::Local<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declaratio ns] >Set(Nan::New<String>("watch").ToLocalChecked(), Nan::New<Integer>(event->wd)); ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8-intern al.h:14:0, from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:27, from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:6 , from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3499:22: note: declared he re bool Set(Local<Value> key, Local<Value> value)); ^ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8config.h:328:3: note: in defi nition of macro ‘V8_DEPRECATED’ declarator __attribute__((deprecated(message))) ^~~~~~~~~~ ../src/bindings.cc:263:87: warning: ‘bool v8::Object::Set(v8::Local<v8::Value>, v8::Local<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declaratio ns] Set(Nan::New<String>("mask").ToLocalChecked(), Nan::New<Integer>(event->mask)); ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8-intern al.h:14:0, from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:27, from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:6 , from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3499:22: note: declared he re bool Set(Local<Value> key, Local<Value> value)); ^ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8config.h:328:3: note: in defi nition of macro ‘V8_DEPRECATED’ declarator __attribute__((deprecated(message))) ^~~~~~~~~~ ../src/bindings.cc:264:91: warning: ‘bool v8::Object::Set(v8::Local<v8::Value>, v8::Local<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declaratio ns] Nan::New<String>("cookie").ToLocalChecked(), Nan::New<Integer>(event->cookie)); ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8-intern al.h:14:0, from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:27, from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:6 , from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3499:22: note: declared he re bool Set(Local<Value> key, Local<Value> value)); ^ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8config.h:328:3: note: in defi nition of macro ‘V8_DEPRECATED’ declarator __attribute__((deprecated(message))) ^~~~~~~~~~ ../src/bindings.cc:267:104: warning: ‘bool v8::Object::Set(v8::Local<v8::Value>, v8::Local<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declarati ons] ing>("name").ToLocalChecked(), Nan::New<String>(event->name).ToLocalChecked()); ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8-intern al.h:14:0, from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:27, from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:6 , from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3499:22: note: declared he re bool Set(Local<Value> key, Local<Value> value)); ^ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8config.h:328:3: note: in defi nition of macro ‘V8_DEPRECATED’ declarator __attribute__((deprecated(message))) ^~~~~~~~~~ ../src/bindings.cc:275:66: warning: ‘v8::Local<v8::Value> v8::Object::Get(v8::Lo cal<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declarations] Local<Value> value = handle->Get(Nan::New<Integer>(event->wd)); ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8-intern al.h:14:0, from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:27, from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:6 , from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:3553:51: note: declared he re V8_DEPRECATED("Use maybe version", Local<Value> Get(Local<Value> key)); ^ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8config.h:328:3: note: in defi nition of macro ‘V8_DEPRECATED’ declarator __attribute__((deprecated(message))) ^~~~~~~~~~ ../src/bindings.cc:279:34: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(v8 ::Local<v8::Object>, int, v8::Local<v8::Value>*) const’ is deprecated [-Wdepreca ted-declarations] callback.Call(handle, 1, argv); ^ In file included from ../src/node_inotify.h:14:0, from ../src/bindings.h:4, from ../src/bindings.cc:2: ../../nan/nan.h:1722:3: note: declared here Call(v8::Local<v8::Object> target ^~~~ ../src/bindings.cc:285:34: error: no matching function for call to ‘v8::Value::T oString()’ handle->Delete(wd->ToString()); ^ In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:67 :0, from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:2668:44: note: candidate: v8::MaybeLocal<v8::String> v8::Value::ToString(v8::Local<v8::Context>) const V8_WARN_UNUSED_RESULT MaybeLocal<String> ToString( ^~~~~~~~ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:2668:44: note: candidate expects 1 argument, 0 provided In file included from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8-intern al.h:14:0, from /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:27, from /home/kevin/.cache/node-gyp/12.20.0/include/node/node.h:6 , from ../src/node_inotify.h:5, from ../src/bindings.h:4, from ../src/bindings.cc:2: /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:2684:31: note: candidate: v8::Local<v8::String> v8::Value::ToString(v8::Isolate*) const Local<String> ToString(Isolate* isolate) const); ^ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8config.h:328:3: note: in defi nition of macro ‘V8_DEPRECATED’ declarator __attribute__((deprecated(message))) ^~~~~~~~~~ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8.h:2684:31: note: candidate expects 1 argument, 0 provided Local<String> ToString(Isolate* isolate) const); ^ /home/kevin/.cache/node-gyp/12.20.0/include/node/v8config.h:328:3: note: in defi nition of macro ‘V8_DEPRECATED’ declarator __attribute__((deprecated(message))) ^~~~~~~~~~ inotify.target.mk:112: recipe for target 'Release/obj.target/inotify/src/binding s.o' failed make: *** [Release/obj.target/inotify/src/bindings.o] Error 1 make: Leaving directory '/home/kevin/reactor/ext/MQTTController/node_modules/ino tify/build' kevin@NUC50:~/reactor/ext/MQTTController$ -
Seems like something is broken or out of date in your nodejs installation. How did you install node? And what version is it (run
node -v) -
Yeah, that's going to be a problem. Version 16.13 is the current, I believe, and would be a good choice.
-
Thankyou - that's worked. I had assumed the appropriate version of node was part of the Docker container.
So pleased to have found this as I use HA, MQTT, Hubitat extensively plus OpenHAB and Homey to a lesser extent so glad you are intending to support those two eventually.
-
It is part of the container, but you are not running in the container. That is a possibility, though, and I tried it, it seems to work, so an alternative to installing (or upgrading) nodejs outside of the container seems to be:
docker exec -it reactor /bin/sh cd /var/reactor/ext/MQTTController ./install.sh exitI'll add this to the installation docs for MQTTController.
-
All working well. However in the topic structure for echoed devices (from Hubitat anyway) the <entity-id> is used. Is it possible to instead or even better as well as, include the entity-name ?
reactor/<mqtt-id>/<ctrl-id>/<entity-id>/state/<capability-name>perhaps
reactor/<mqtt-id>/<ctrl-id>/<entity-name>/<entity-id>/state/<capability-name> -
The entity name can be changed or duplicated and is not an appropriate unique identifier for a device.
-
-
@xappo OK. And what about receiving messages for inbound action requests? Same
entity-name/entity-idconstruction? If you know the correct entity ID to form that message, what value is the name? If you don't know the ID and only use the name, how do you specify that, and what if the name isn't unique then? And what if the name and ID conflict, or an entity can be found for one but not the other (i.e. they don't match)? I'm not opposed to what you're proposing, but I want you to help me think through the consequences of it.@xappo said in MQTT interface... time for some testing. Where are my experts?:
Having no easily human identifiable topic is not helpful to other integrations.
I think that's a bit of a reach. The whole MQTT environment is so unstructured and freeform, with so many inconsistencies between players, that things like unique IDs (or MAC addresses or other cryptic and "hard to read" identifiers) are a regular occurrence, and anybody who uses MQTT a lot is used to it.
-
The incoming action request message to a topic must be complete with all segments as you can't wildcard a publish command. So the <entity-id> will always be unique and present there. You could should you wish subscribe to the topic from your code ignoring any <entity-name> segment with a + wildcard as you don't process it. So that should work fine.
Human readability.. I agree it's a bit of a reach but my whole system is MQTT based with over 10K topics and 1K+ devices - remembering what they all are and linking to or from those topics from other controllers requires some hints as to what those devices are. Later examination of logic requires understanding what devices are related. Having to refer back to Reactor config each time to identify a device isn't practical (or user friendly).
-
Good stuff. Let me see what I can cook up.
-
OK. Version 22008 of MQTTController is up on the downloads site (under extras).
New configuration key that you can put in the
echosection: setentity_identifiertocombinedand the telemetry topics will include the entity name; it adds another level to the topic as you suggested. This has no effect on received messages for entity actions; those still require the ID (but it's a secret/undocumented feature--you can give it the name instead of an ID and it will work if the name is unique), and the structure of the topic is the same (i.e. same number of levels, not changed). Online docs are updated as well. -
This is working well - thank you for the prompt update.
For me having the <entity-name> before <entity-id> in the topic hierarchy would have been more informative as you can then see a list of names rather than numbers in expanded topics with say MQTT explorer rather than having to drill down in each one, but I totally understand why it is so much easier in terms of your existing implementation to position it afterwards and this is very workable too.
Thank you again.
Kevin -
No worries. Version 22009 now. You can now set
entity_identifiertoid/name(as a synonym forcombined) orname/id. I'll fix up the documentation later. -
I notice in the MQTT code you subscribe to the root level with a wildcard which means you receive every payload update. On my (untypical) broker this will produce 10’s of message per second. The good thing is Reactor seems to handle it but obviously it’s resource wasteful. Did you do this with a view to implementing discovery across the broker perhaps?
Currently it might seem better to just pull the necessary topics from the MQTTController section of reactor.yaml even though this may result in lots of individual subscribes?
Also just to mention I’ve got my first CBusController half written. It discovers and creates entities for all the 100+ lights I have on my Schneider C-Bus lighting but needs some refining. Learning as I go. Having the MQTT code as an example has been invaluable to me.
Would you be up to releasing the Hubitat and HomeAssistant controller code as examples? I think that would help people in authoring new controllers, as might a minimal code template that does nothing really.
-
When I started writing MQTTController I didn't quite know where it was going to end up or how it was going to get there. It moved a lot from its starting point. I can definitely "tune up" the subscriptions, but discovery is in the mix (it captures certain discovery messages to debug currently but doesn't do much else with them -- still under consideration).
Did you find the probably dated but maybe marginally helpful docs here? https://reactor.toggledbits.com/docs/Building-Controllers/
I've been really busy this week, and suffered a long Internet outage that just recovered a couple of hours ago, but when I'm caught up I'll quickly update some key points and concepts in there.HubitatController and HassController are very complex pieces of machinery that I don't think would make good examples. Now that I have a few done, one of my tasks is go back and boil out some of the work into common methods or helper classes. I have a lot of work to do on the server API side.
Many thanks for that